From: Joe Perches <joe@perches.com>
To: Camylla Cantanheide <c.cantanheide@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
navid.emamdoost@gmail.com, sylphrenadin@gmail.com,
nishkadg.linux@gmail.com, stephen@brennan.io,
devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function
Date: Tue, 14 Apr 2020 20:09:07 -0700 [thread overview]
Message-ID: <414a17ea0978cf65020d9be84f257fe85edc62ab.camel@perches.com> (raw)
In-Reply-To: <CAG3pEr+huVACoP7sTMALYfE46dc+D8DdGPF0ky6EShd4eXD9eg@mail.gmail.com>
On Tue, 2020-04-14 at 22:18 -0300, Camylla Cantanheide wrote:
> Em ter., 14 de abr. de 2020 às 09:35, Dan Carpenter <
> dan.carpenter@oracle.com> escreveu:
[]
> > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c
[]
> > > + target_content = macaddr[0] << 16 |
> > > + macaddr[0] << 24 |
> > > + (u32)us_config;
And Camylla, this statement should be
+ target_content = macaddr[0] << 16 |
+ macaddr[1] << 24 |
+ (u32)us_config;
Not a repeated [0]
> > > +
> > > + write_nic_dword(dev, WCAMI, target_content);
> > > + write_nic_dword(dev, RWCAM, target_command++);
> > > +
> > > + /* MAC */
> > > + target_content = macaddr[2] |
> > > + macaddr[3] << 8 |
> > > + macaddr[4] << 16 |
> > > + macaddr[5] << 24;
prev parent reply other threads:[~2020-04-15 3:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 3:01 Camylla Goncalves Cantanheide
2020-04-13 3:01 ` [PATCH 2/2] staging: rtl8192u: Renames variables in " Camylla Goncalves Cantanheide
2020-04-13 12:50 ` Greg KH
2020-04-13 12:50 ` [PATCH 1/2] staging: rtl8192u: Refactoring " Greg KH
2020-04-13 15:39 ` Joe Perches
2020-04-14 12:33 ` Dan Carpenter
2020-04-14 16:01 ` Joe Perches
2020-04-14 18:32 ` Dan Carpenter
[not found] ` <CAG3pEr+huVACoP7sTMALYfE46dc+D8DdGPF0ky6EShd4eXD9eg@mail.gmail.com>
2020-04-15 3:09 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414a17ea0978cf65020d9be84f257fe85edc62ab.camel@perches.com \
--to=joe@perches.com \
--cc=c.cantanheide@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=navid.emamdoost@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=stephen@brennan.io \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®