From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26FCC433FE for ; Mon, 21 Nov 2022 20:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbiKUUZ7 (ORCPT ); Mon, 21 Nov 2022 15:25:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiKUUZz (ORCPT ); Mon, 21 Nov 2022 15:25:55 -0500 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA9FF57B72; Mon, 21 Nov 2022 12:25:53 -0800 (PST) Message-ID: <414c8bf5-f2ce-e042-05ff-0e463ab2613f@gentoo.org> Date: Mon, 21 Nov 2022 21:25:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 From: zzam@gentoo.org Subject: Re: [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call Content-Language: en-GB To: cgel.zte@gmail.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot References: <20220606014433.290667-1-chi.minghao@zte.com.cn> In-Reply-To: <20220606014433.290667-1-chi.minghao@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 06.06.22 um 03:44 schrieb cgel.zte@gmail.com: > From: Minghao Chi > > release_firmware() checks for NULL pointers internally so checking > before calling it is redundant. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/media/dvb-frontends/si2165.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c > index ebee230afb7b..3d167ca670a4 100644 > --- a/drivers/media/dvb-frontends/si2165.c > +++ b/drivers/media/dvb-frontends/si2165.c > @@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state) > ret = 0; > state->firmware_loaded = true; > error: > - if (fw) { > - release_firmware(fw); > - fw = NULL; > - } > + release_firmware(fw); > + fw = NULL; > > return ret; > } Acked-by: Matthias Schwarzott