From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Matthew Leach <matthew.leach@collabora.com>,
Jeff Johnson <jjohnson@kernel.org>,
Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
Baochen Qiang <quic_bqiang@quicinc.com>,
Ramya Gnanasekar <quic_rgnanase@quicinc.com>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: Kalle Valo <kvalo@kernel.org>,
Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
P Praneesh <quic_ppranees@quicinc.com>,
Sriram R <quic_srirrama@quicinc.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>,
Nicolas Escande <nico.escande@gmail.com>,
Rameshkumar Sundaram <quic_ramess@quicinc.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Subject: Re: [PATCH v3] wifi: ath12k: fix survey indexing across bands
Date: Mon, 20 Jul 2026 13:58:48 +0800 [thread overview]
Message-ID: <4153e4d7-6ede-429c-b059-84e48371d35f@oss.qualcomm.com> (raw)
In-Reply-To: <20260703-ath12-survey-band-fix-v3-1-2fb050c2505a@collabora.com>
On 7/3/2026 11:56 PM, Matthew Leach wrote:
> When running 'iw dev wlan0 survey dump' the values for the channel busy
> time have the same sequence across bands. This is caused by indexing
> into the ath12k survey array using a band-local index rather than the
> global index passed by mac80211. This results in surveys for 5 GHz and 6
> GHz channels returning values from 2.4 GHz slots, making the survey
> unusable on those bands. Further, there are redundant survey slots for
> multi-radio/single-phy instances.
>
> Fix by moving the survey data into ath12k_hw so multiple radios under a
> single wiphy share one table, and index into it using the global
> mac80211 index. A new spinlock in ath12k_hw serialises access to the
> survey array, which is now shared across all radios under a single hw.
>
> Band busy-times Before this fix:
>
> 2.4 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5
> 5 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5
> 6 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5
>
> After this fix, times are independent:
>
> 2.4 GHz: 23, 5, 5, 12, 2, 12, 26, 5, 3, 1, 27
> 5 GHz: 30, 40, 29, 27, 118, 118, 112, 120, 11, 11, 11
> 6 GHz: 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1
>
> Tested-on: wcn7850 hw2.0 PCI WLAN.IOE_HMT.1.1-00018-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1
>
> Fixes: 4f242b1d6996 ("wifi: ath12k: support get_survey mac op for single wiphy")
> Signed-off-by: Matthew Leach <matthew.leach@collabora.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
next prev parent reply other threads:[~2026-07-20 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 15:56 Matthew Leach
2026-07-19 13:51 ` Rameshkumar Sundaram
2026-07-20 5:58 ` Baochen Qiang [this message]
2026-07-20 14:01 ` Jeff Johnson
2026-07-20 14:22 ` Jeff Johnson
2026-07-21 20:02 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4153e4d7-6ede-429c-b059-84e48371d35f@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kernel@collabora.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthew.leach@collabora.com \
--cc=nico.escande@gmail.com \
--cc=quic_bqiang@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_ppranees@quicinc.com \
--cc=quic_pradeepc@quicinc.com \
--cc=quic_ramess@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
--cc=quic_srirrama@quicinc.com \
--cc=quic_vthiagar@quicinc.com \
--cc=rameshkumar.sundaram@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®