From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A23338C427 for ; Tue, 3 Mar 2026 09:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772531785; cv=none; b=LpyksLh+Ips0ZLJvdl1l4I3QRIugFM2OixG8CvcK+sVmNmE4PaIRz41TFrXfYa5Sy7EOExHhFuW/Sj2pGyrqFSY5pscLoRBancxplOU4ArvTOTpPKsa7eTqdIOzeY8EtwNWTjWCGuIjB5chjd46Mv/Inc20okaLEHXT9kw1yA2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772531785; c=relaxed/simple; bh=jAqjFZ1cVljCe046fBFPJ/ldGEkf19iTq1wr8cQMmOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VE1ygxi+meWER7keXYu2BGZJrELVkEPuqIZ3tTiBnXXfltUpOie8OiXzOXhX3xTCzDQAPSIjFkdEiQWlAHkxJ1W7V1nE2sGMEdyfpjSEuOqmf+1dLmDpAJHzByzQARnUeFQPcNaXuGlWHneewUx3cOqm3wBl8VQYm46zDeN8rpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LsVNi2gX; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsVNi2gX" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso49298065e9.3 for ; Tue, 03 Mar 2026 01:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772531781; x=1773136581; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uJ4zYk7rVbgDrmP0BB3MrmvGdOwTNgKEAmJ+HRQXJxs=; b=LsVNi2gXhm8X482hlGbVJG4adPpi8k4iZ179m3wjWA7mgIs9QBfJrhXsy1PoPy6wGt EfbvSo2tofXgamK4IrasnZboOt4xMYWiDqRe5NkTePs9t3xTrW/NsX0a1LOu8M4hOqCy R9kk2I2+Yf5smh/F3A8e4UhdHYoLV1Iwqy7oIdPHwjVlsEOXn+6f6cS8aAKBs/K0G85X RiSNNdhMzmZFZjfMte0RzhH+6dGa8qo6dP0oMwcb1NYKzLYZUBC9Ed/LvS/IWWHm8vcp 4pMly472anrHT+MYHuAUPG+fQrHM5AW85Nq2/YRaCZ36zGZahSqZLSy10wV2xY/utI1w FreQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772531781; x=1773136581; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uJ4zYk7rVbgDrmP0BB3MrmvGdOwTNgKEAmJ+HRQXJxs=; b=gMk+m1N/604Ajug+3Z2OSpuqcoJem5kpK6H7wNwI1Nb4YOyCN0qMpRAG7clQzTe0+z yo9NBr4tqRKG0lJbGlisLm9R8pZ+McXChUctNOrNbIssaM4KLZXBfdUgPiSxCo2HFmEI FTaN+zi7ztKZQSAr1iXmeMBULDyBrAF5/CtyMo+Bx8FqptFh/7VN53Sg27TBnSmN7Q7F ZB49XrCcPG9jcLTiwH4fnA2PKsVvegwNAHQaCGEUTuLeCB6aLXLc3i/KShPqVfbCysjE P/nwWsrgLbcZYFLJ+dH6oUAFZVflGNSsFtwLsjPEYPGaS1NFH8lYHWjGlBFBPF+2a27k GBTQ== X-Forwarded-Encrypted: i=1; AJvYcCVjE720YdTstXwPkP2jN5ADtODLyEH13rC8in2JzH0mOc3pNauzLlM/OZUsyX4DlLYs1QLihKuNnKeKQ3E=@vger.kernel.org X-Gm-Message-State: AOJu0YxG4GKuOb0ii0Oouiu4nnUycLVM+/is1T/Yrd1QlbxyJLJW3fit rbAqgs3mdSZPlbVNBynzNiV7RNCdt6pqEUbadBbeECH/W0oOiGCwmuPyNXFhq23YiKY= X-Gm-Gg: ATEYQzyguRIznW8NzX1anycFPUkDONrC5CF2EgRQg6EZYj+o2P41N1eXWUNHT2cL2Q2 y+x+vfgNi+ElDgxBgwoiaPfK8VrM0eJXqtLMj25zo5wcrC1Vv7ttlk6U/z5wFQDw1CnHamGPgJq kklktud9tRy/FMJGHV4A9N3JKNNintkKcyU9TEFHTm925I8goWKqNNb2l538I+ekhN+A42iI9eE SDuKugv2XSlHkl1uAH+HPm0ef5ItLfJOtg/3NMKl7OnouSO5bx5EpCFJ2pkJC53xOD/U7uxK44E j+DlcS9X1zhqK4StoqoJxhPD28x3jeT3CafSxRiDsLYHLpxpqnqYw5ob8JiXXXxKPq6cXv822PJ ZZiUnOQfdBCd58gKsdXrIXWXfUaapvQS+MZZ1IWh/o7UHuLA79rEGB+mond56bP0nOrR5U2R1fL nfJeY9QK2QYJvb/Btrg4q1eS2uMsTl9vNG+I8joRIzs/WvJOLL614wk1JxLSDWtrAB X-Received: by 2002:a05:600c:1d0e:b0:483:acd9:bd18 with SMTP id 5b1f17b1804b1-483c9bc55ecmr267450835e9.1.1772531780790; Tue, 03 Mar 2026 01:56:20 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851335e1f9sm15442435e9.7.2026.03.03.01.56.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 01:56:20 -0800 (PST) Message-ID: <4156dea0-924f-4577-bf54-d5d8928f7adf@linaro.org> Date: Tue, 3 Mar 2026 09:56:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH WIP v4 7/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.1 MIPI CSI-2 C-PHY init To: david@ixit.cz, Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Konrad Dybcio , Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260301-qcom-cphy-v4-0-e53316d2cc65@ixit.cz> <20260301-qcom-cphy-v4-7-e53316d2cc65@ixit.cz> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260301-qcom-cphy-v4-7-e53316d2cc65@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/03/2026 00:51, David Heidelberg via B4 Relay wrote: > From: Luca Weiss > > Add a PHY configuration sequence for the sm8250 which uses a Qualcomm > Gen 2 version 1.2.1 CSI-2 PHY. > > The PHY can be configured as two phase or three phase in C-PHY or D-PHY > mode. This configuration supports three-phase C-PHY mode. > > Signed-off-by: Luca Weiss > Reviewed-by: Konrad Dybcio > Signed-off-by: David Heidelberg > --- > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 112 ++++++++++++++++++++- > 1 file changed, 111 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index c612192ee727a..e48f5c1290173 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -550,6 +550,113 @@ csiphy_lane_regs lane_regs_qcm2290[] = { > {0x0664, 0x3f, 0x00, CSIPHY_DEFAULT_PARAMS}, > }; > > +/* GEN2 1.2.1 3PH */ > +/* 3 entries: 3 lanes (C-PHY) */ > +static const struct > +csiphy_lane_regs lane_regs_sm8250_3ph[] = { > + {0x0990, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0994, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0998, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0990, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0994, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0998, 0x1a, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x098c, 0xaf, 0x01, CSIPHY_DEFAULT_PARAMS}, > + {0x015c, 0x46, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0168, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0104, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x010c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > + {0x0108, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > + {0x0114, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0150, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0188, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x018c, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0190, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0118, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x011c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0120, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0124, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0128, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x012c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0160, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x01cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x01dc, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0984, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0988, 0x05, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0980, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x09ac, 0x35, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x09b0, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0800, 0x0e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > + > + {0x0a90, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a94, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a98, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a90, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a94, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a98, 0x1a, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a8c, 0xaf, 0x01, CSIPHY_DEFAULT_PARAMS}, > + {0x035c, 0x46, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0368, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0304, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x030c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > + {0x0308, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > + {0x0314, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0350, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0388, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x038c, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0390, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0318, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x031c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0320, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0324, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0328, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x032c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0360, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x03cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x03dc, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a84, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a88, 0x05, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0a80, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0aac, 0x35, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0ab0, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0800, 0x0e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > + > + {0x0b90, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b94, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b98, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b90, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b94, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b98, 0x1a, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b8c, 0xaf, 0x01, CSIPHY_DEFAULT_PARAMS}, > + {0x055c, 0x46, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0568, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0504, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x050c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > + {0x0508, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > + {0x0514, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0550, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0588, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x058c, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0590, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0518, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x051c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0520, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0524, 0x7f, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0528, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x052c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0560, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x05cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x05dc, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b84, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b88, 0x05, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0b80, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0bac, 0x35, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0bb0, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0800, 0x0e, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, > +}; > + > /* GEN2 2.1.2 2PH DPHY mode */ > static const struct > csiphy_lane_regs lane_regs_sm8550[] = { > @@ -1134,7 +1241,10 @@ static int csiphy_lanes_enable(struct csiphy_device *csiphy, > break; > case CAMSS_7280: > case CAMSS_8250: > - { > + if (c->phy_cfg == V4L2_MBUS_CSI2_CPHY) { > + regs->lane_regs = &lane_regs_sm8250_3ph[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250_3ph); > + } else { > regs->lane_regs = &lane_regs_sm8250[0]; > regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250); > } > Reviewed-by: Bryan O'Donoghue