From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: make all new mount api fds cloexec by default
Date: Wed, 08 May 2019 15:05:43 +0100 [thread overview]
Message-ID: <4158.1557324343@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190508132218.3617-1-christian@brauner.io>
Christian Brauner <christian@brauner.io> wrote:
> - fd = get_unused_fd_flags(flags & O_CLOEXEC);
> + fd = get_unused_fd_flags(flags | O_CLOEXEC);
That'll break if there are any flags other than O_CLOEXEC.
> - ret = get_unused_fd_flags((flags & FSMOUNT_CLOEXEC) ? O_CLOEXEC : 0);
> + ret = get_unused_fd_flags(flags | O_CLOEXEC);
That'll break because flags is not compatible with what get_unused_fd_flags()
is expecting.
David
next prev parent reply other threads:[~2019-05-08 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 13:22 Christian Brauner
2019-05-08 14:05 ` David Howells [this message]
2019-05-08 14:13 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4158.1557324343@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®