From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749Ab2LQHvh (ORCPT ); Mon, 17 Dec 2012 02:51:37 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:35988 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366Ab2LQHvf (ORCPT ); Mon, 17 Dec 2012 02:51:35 -0500 From: "Rafael J. Wysocki" To: Sivaram Nair Cc: "rafael.j.wysocki@intel.com" , "daniel.lezcano@linaro.org" , "shuox.liu@intel.com" , "akpm@linux-foundation.org" , "yanmin_zhang@intel.com" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage Date: Mon, 17 Dec 2012 08:56:45 +0100 Message-ID: <4160971.sv9ruOS3QC@vostro.rjw.lan> User-Agent: KMail/4.9.3 (Linux/3.7.0; KDE/4.9.3; x86_64; ; ) In-Reply-To: <20121217073815.GM10090@sivaramn-lnx> References: <1355491060-970-1-git-send-email-sivaramn@nvidia.com> <39891276.jhMMUpZpil@vostro.rjw.lan> <20121217073815.GM10090@sivaramn-lnx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, December 17, 2012 09:38:15 AM Sivaram Nair wrote: > On Sat, Dec 15, 2012 at 01:03:02AM +0100, Rafael J. Wysocki wrote: > > On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > > > cpuidle_state->power_usage is signed; so change the corresponding sysfs > > > ops to output signed value instead of unsigned. > > > > What's actually wrong with printing it as an unsigned int? > > power_usage could have negative values (for example cpuidle/driver.c > inits this value to -1, -2 etc. when drv->power_specified is not set) and > these shows up badly in the sysfs output. Does "badly" mean "as big positive numbers"? Should we actually print them at all in those case? Perhaps it'll be better to make the file appear empty then? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.