From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51B81258EDA; Mon, 6 Apr 2026 15:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775489478; cv=none; b=r3Yuc3X01vgJAX4RmZI7HgfD4MDXg3SafvbkP3fJqWGpKX36M492y0EQegAqJXpYANIQsANJBOwKtfFPVbE+H/GS3jnYkXSJMLXaY1TzvJKq0nVCoO7xEGOZg+IOf8awOYrEltQLXPHQFM0GwhVE6haI9K7lyGJsdso8nxiWdR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775489478; c=relaxed/simple; bh=S6MR2YNBRSzDuJOiJOdwNpywu7sQ3wKTTf2citvbdNA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=mQeqwIfnar3yFDVEkkpnvIPF10Th4P0UtJaaDA1kQ5+v5usUcR3g0NaoEM2dhZ3KF3btfZxJEsAaraYn91Ym4GJmREwoFYgoLSD12W3I+LAWUSH77cYgUZvP4vPXWlRVCMh/sMAkVozVvn5FXMSY5tQd3FB8TIN+V4hjQRZJR14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=d9NfMqx/; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="d9NfMqx/" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B61A9112349; Mon, 6 Apr 2026 17:31:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1775489475; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=xTqqo0bM2Xp/vABBfMxTtslTbC0nEcFdtU9RVWpzvC0=; b=d9NfMqx/h4AterwS3pb9uaO184+AEpR9/8Mm0vRvs9yLYWBbiUUr0V5H+81Jdjoh0vbiA3 A2J+qhLil58e1MlrZebVNYvehykoCA5MxzaQE8VqsCOURduIF3P7stxf0sodc2o3M7r1hy 6WWmNSpk92X6H4x0dgjtkWbtWfKSk/DxPBFKIDtCNibREu0z3QJuK3eEF/JIcq9orKnxxY idfyFswFphl+FYR9vhGCb2/+4LKCM3e0QbCV36okK+Nt+ofOTmDsA6GBHFTvp1W2qWFRwy IFipw4+Mq8QhrdYPO+zQjtg71kprF/iHhTGmFJKCfkdjznlhTCPoRJofsT4ZWQ== Message-ID: <41641a5c-8da1-4696-888c-454e6bf2eea2@nabladev.com> Date: Mon, 6 Apr 2026 16:49:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: imx8mn-vhip4-evalboard-v2: Correct interrupt flags To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Fedor Ross , Shawn Guo , Shengjiu Wang , Viorel Suman , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260406063810.25531-4-krzysztof.kozlowski@oss.qualcomm.com> <20260406063810.25531-5-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260406063810.25531-5-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 4/6/26 8:38 AM, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 => IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 => IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted the > same logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Fixes: 5eb7405db99b ("arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Marek Vasut