From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbcFXT6a (ORCPT ); Fri, 24 Jun 2016 15:58:30 -0400 Received: from megous.com ([83.167.254.221]:52751 "EHLO xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbcFXT61 (ORCPT ); Fri, 24 Jun 2016 15:58:27 -0400 Subject: Re: [PATCH 01/14] ARM: dts: sun8i: Add SID node To: Chen-Yu Tsai References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-2-megous@megous.com> Cc: dev , linux-arm-kernel , Josef Gajdusek , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Message-ID: <416577ad-f8d0-d12a-a092-9b22ad2f31f1@megous.com> Date: Fri, 24 Jun 2016 21:58:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="64pm9SiT2NQTNuK9l2erw8I5rTrCasVJt" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --64pm9SiT2NQTNuK9l2erw8I5rTrCasVJt Content-Type: multipart/mixed; boundary="GcwkkabcLNLuITlmR4fee1MTVn1g0nqGx" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Chen-Yu Tsai Cc: dev , linux-arm-kernel , Josef Gajdusek , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Message-ID: <416577ad-f8d0-d12a-a092-9b22ad2f31f1@megous.com> Subject: Re: [PATCH 01/14] ARM: dts: sun8i: Add SID node References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-2-megous@megous.com> In-Reply-To: --GcwkkabcLNLuITlmR4fee1MTVn1g0nqGx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, thank you for the review. On 24.6.2016 04:41, Chen-Yu Tsai wrote: > On Fri, Jun 24, 2016 at 3:20 AM, wrote: >> From: Josef Gajdusek >> >> Add a node describing the Security ID memory to the Allwinner H3 .dtsi= file. >> >> Signed-off-by: Josef Gajdusek >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i= -h3.dtsi >> index 4a4926b..172576d 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -389,6 +389,13 @@ >> #size-cells =3D <0>; >> }; >> >> + sid: eeprom@01c14000 { >> + compatible =3D "allwinner,sun4i-a10-sid"; >=20 > This has been discussed before. The hardware is not compatible. > The write control registers are at different offsets. I'm not sure what you mean by write control registers. Code in sunxi_sid.c implements only read access to the nvram. Can you pelase elaborate? Ondrej >=20 > ChenYu >=20 >> + reg =3D <0x01c14000 0x400>; >> + #address-cells =3D <1>; >> + #size-cells =3D <1>; >> + }; >> + >> usbphy: phy@01c19400 { >> compatible =3D "allwinner,sun8i-h3-usb-phy"; >> reg =3D <0x01c19400 0x2c>, >> -- >> 2.9.0 >> --GcwkkabcLNLuITlmR4fee1MTVn1g0nqGx-- --64pm9SiT2NQTNuK9l2erw8I5rTrCasVJt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbZDcAAoJEG5kJsZ3z+/xTisP/RqhxIrq3H1QJyNswdeIrFvl rF8zm/1rqRLdDeKrBdzwc1KwGSRmsyB4lvbtdK2gvMukSjHPZwl3AwoC6ck0WN0Z PsfJ5FYem8+/asLtWPqrEp6trGAkDEuRiXsHER7Ooi/isUVtF8FjX6iv1WzCMl20 ZHYfsjVhFBwGWXcT5phWq+UaK2GisA8e1Xa4EKpDsezziXtSncsDwM+wzTf7yn3U 6PEW8W/ljZx0nKDZRhfQXNl2IFY4s19jRGvj8kno3kRluGCt5AwpsTB2NHavZT5g FmFx5ExJySPuuNehlkyRsa7aGl0lZlhmUxXs9893XiNBSObQgMXR94ZgjzLZFxbk YpFrxMoV/lxla4bnDa+2tgz2SndzMKWidmR+nQb1BpMKXvjyVK+UhATjIaBq9cOv iQpakAzPWEt6oyLNT7jJGxRsB1tfyOCam8whRcJuDmsAIj9Wm3Abf1jBjHA6PZ1h R2SV/2uqlIWoX9v+RFMrNmwHYHLelfIrf90CuLQOr9asLaaygxNgQF75zI9OSqce dGBvGlmCSzwCv8yJQIC3pAjvtL+0kH3DsmWyg3lPdyyC0Rur5VEIafbXxcuSsOFa Zb9kU8Cjz5fmsTOkPwUhYeVDnmo9JggKS24XoXbx29lSCiaFYPBIRn9708V9a11Q PfYj3vzkPRsvG7GEPhJc =vXVH -----END PGP SIGNATURE----- --64pm9SiT2NQTNuK9l2erw8I5rTrCasVJt--