From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Saravana Kannan <skannan@codeaurora.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories
Date: Wed, 28 Oct 2015 09:16:45 +0100 [thread overview]
Message-ID: <4167825.7F75u7l572@vostro.rjw.lan> (raw)
In-Reply-To: <20151016055118.GR19018@linux>
On Friday, October 16, 2015 11:21:18 AM Viresh Kumar wrote:
> On 15-10-15, 12:25, Saravana Kannan wrote:
> > Btw, does a Review-by have an implicit Acked-by?
>
> I have attended a session at Linaro Connect where this was discussed
> and the answer was:
>
> Acked-by: is more of a general agreement from the person that he is
> fine with the patch, but he might not have done a very careful review
> and he isn't really responsible for the patch's content.
>
> Reviewed-by: is a more strict tag and implies that the reviewer has
> reviewed it at his best and he is as much responsible for the content
> of the patch as the author.
That's a bit too much IMO. It means "I have carried out a detailed review
of this patch and haven't found problems in it." How much responsibility
that implies is not so clear (evidently, there are differing opinions
regarding that).
Thanks,
Rafael
next prev parent reply other threads:[~2015-10-28 7:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1444924623.git.viresh.kumar@linaro.org>
2015-10-15 16:05 ` [PATCH V2 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to copy a mask Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 2/5] cpufreq: create cpu/cpufreq at boot time Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 3/5] cpufreq: remove cpufreq_sysfs_{create|remove}_file() Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Viresh Kumar
2015-10-15 19:25 ` Saravana Kannan
2015-10-15 21:35 ` Rafael J. Wysocki
2015-10-16 5:51 ` Viresh Kumar
2015-10-28 8:16 ` Rafael J. Wysocki [this message]
2015-10-28 8:28 ` Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 5/5] cpufreq: postfix policy directory with the first CPU in related_cpus Viresh Kumar
2015-10-15 19:14 ` Saravana Kannan
2015-10-16 7:08 ` Viresh Kumar
2015-10-16 7:11 ` [PATCH V3 " Viresh Kumar
2015-10-16 19:50 ` Saravana Kannan
2015-10-17 4:29 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4167825.7F75u7l572@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=skannan@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®