From: Pierre Ossman <drzeus-list@drzeus.cx>
To: linux-kernel@vger.kernel.org, Russell King <rmk+lkml@arm.linux.org.uk>
Subject: [PATCH] MMC power cycle
Date: Sun, 10 Oct 2004 14:22:18 +0200 [thread overview]
Message-ID: <4169297A.8040602@drzeus.cx> (raw)
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
I think I've found the special magic required to initialise my problem
card without causing issues with other cards/controllers.
After the initial scan to determine a correct voltage, the host cycles
power to reboot any cards (like mine) that have gone into shutdown. This
patch works with the two cards I have (one good, one bad).
Russell, do you think this will work in all discussed scenarios?
Rgds
Pierre
[-- Attachment #2: mmc-powercycle.patch --]
[-- Type: text/x-patch, Size: 1038 bytes --]
Index: linux-wbsd/drivers/mmc/mmc.c
===================================================================
--- linux-wbsd/drivers/mmc/mmc.c (revision 71)
+++ linux-wbsd/drivers/mmc/mmc.c (working copy)
@@ -666,13 +666,24 @@
host->ocr = mmc_select_voltage(host, ocr);
/*
- * Since we're changing the OCR value, we seem to
- * need to tell some cards to go back to the idle
- * state. We wait 1ms to give cards time to
- * respond.
+ * Some cards shut down when receiving an OCR of
+ * zero. But since they send their mask before
+ * shutting down we can still calculate a correct
+ * voltage. To get them back to life we need to
+ * cycle power.
+ *
+ * When changing OCR values we also need to put
+ * the cards in idle state. But since we restart
+ * them here that point is moot.
*/
if (host->ocr)
+ {
+ mmc_power_off(host);
+ mmc_delay(100);
+ mmc_power_up(host);
+
mmc_idle_cards(host);
+ }
} else {
host->ios.bus_mode = MMC_BUSMODE_OPENDRAIN;
host->ios.clock = host->f_min;
reply other threads:[~2004-10-10 12:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4169297A.8040602@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®