mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Zenghui Yu <yuzenghui@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<wanghaibin.wang@huawei.com>, <tanhuazhong@huawei.com>
Subject: Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region
Date: Tue, 27 Oct 2020 09:42:01 +0800	[thread overview]
Message-ID: <416bed1a-ce64-d326-3a7a-a8c8258c0bac@huawei.com> (raw)
In-Reply-To: <20201026182557.43dcb486@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

On 2020/10/27 9:25, Jakub Kicinski wrote:
> On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote:
>>> Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF doing FLR")  
>>
>> The correct Fixes tag should be:
>>
>> Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hclgevf_uninit")
> 
> Why is that?
> 
> Isn't the issue the order of cmd vs pci calls? e3338205f0c7 only takes
> the pci call from under an if, the order was wrong before.

You are right, the e3338205f0c7 only add the missing hclgevf_pci_uninit()
when HCLGEVF_STATE_IRQ_INITED is not set.

So I think the tag you provided is correct, thanks.

> .
> 

  reply	other threads:[~2020-10-27  1:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  5:15 Zenghui Yu
2020-10-23  6:22 ` Yunsheng Lin
2020-10-23  7:01   ` Zenghui Yu
2020-10-26 23:13     ` Jakub Kicinski
2020-10-27  1:24       ` Yunsheng Lin
2020-10-27  1:25         ` Jakub Kicinski
2020-10-27  1:42           ` Yunsheng Lin [this message]
2020-10-27  3:27             ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416bed1a-ce64-d326-3a7a-a8c8258c0bac@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=tanhuazhong@huawei.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®