From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0732D46A1 for ; Fri, 21 Nov 2025 07:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763708983; cv=none; b=axdCS+PhOKkL2KgaH84DqKtdmVIIt8buPDv0wR/mHA2rN4lg2L0s8zMzQ88L7bZ12cEU4VqLffvhnT4A/7E+f2Vvcfv3tZ8kyh97ClP4Ku+QylX2UT3d/0/qd3lMF0Q5yLYSmKIO7AKhE+LJbSVX0cOd313U9IkY8QNq23QdkR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763708983; c=relaxed/simple; bh=wC+6btSS0Krm5+iwoRz0Rbf122DKbT7noFiwL/keFgE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=X5q+dlpXlTRvKp+7nsv+NvG4tBvKg5bWKHqnD7GC8c0Y2nVHbp+6T56icjj6+xs9cAjMy70vRSVfXeNuxpalGyeDOZSTnu8xPhQM88q/kLQo4s+iX7HVP/e7fhL5z9mZlIoVVE8FVWGdGPusfCIj/EI6L/WW7+iwOsfCLvrY04A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nr3IiISk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6z2N5tpC; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nr3IiISk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6z2N5tpC; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nr3IiISk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6z2N5tpC"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nr3IiISk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6z2N5tpC" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A1012189C; Fri, 21 Nov 2025 07:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763708978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjAp9ozt7wqK8M7Wx7/Wv+fJWEahVbkHnKlMzx+Cvaw=; b=nr3IiISkiwrUTqZQLOaPbvDw66NWyOTcTLyI/YGvBTMUvOei5QHV/L2JIS+6B34tdcYSQH gLzRq+SUMVoxTfOaYV2wLQtUB3sRGtpx2fDSknS8eJMTsxxQnYZkr15K08Aenw8Kwjt2dz gxX3KVBZh/IwV6aWGf6NqfqCymFwjdg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763708978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjAp9ozt7wqK8M7Wx7/Wv+fJWEahVbkHnKlMzx+Cvaw=; b=6z2N5tpC85tLntGJg3ldGk5e79c/SCu4Lt1KAXg9GPi7yq+E0UxFfHLhUycpx37d0adnFB VdFVdtl9faoHEXDg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763708978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjAp9ozt7wqK8M7Wx7/Wv+fJWEahVbkHnKlMzx+Cvaw=; b=nr3IiISkiwrUTqZQLOaPbvDw66NWyOTcTLyI/YGvBTMUvOei5QHV/L2JIS+6B34tdcYSQH gLzRq+SUMVoxTfOaYV2wLQtUB3sRGtpx2fDSknS8eJMTsxxQnYZkr15K08Aenw8Kwjt2dz gxX3KVBZh/IwV6aWGf6NqfqCymFwjdg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763708978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjAp9ozt7wqK8M7Wx7/Wv+fJWEahVbkHnKlMzx+Cvaw=; b=6z2N5tpC85tLntGJg3ldGk5e79c/SCu4Lt1KAXg9GPi7yq+E0UxFfHLhUycpx37d0adnFB VdFVdtl9faoHEXDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 038553EA61; Fri, 21 Nov 2025 07:09:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rUDsOjEQIGmLbwAAD6G6ig (envelope-from ); Fri, 21 Nov 2025 07:09:37 +0000 Message-ID: <4171e102-855b-43a2-bef0-dc0b42868827@suse.de> Date: Fri, 21 Nov 2025 08:09:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/8] blk-mq-sched: unify elevators checking for async requests To: Yu Kuai , axboe@kernel.dk, nilay@linux.ibm.com, bvanassche@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251121052901.1341976-1-yukuai@fnnas.com> <20251121052901.1341976-3-yukuai@fnnas.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20251121052901.1341976-3-yukuai@fnnas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,fnnas.com:email] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: On 11/21/25 06:28, Yu Kuai wrote: > bfq and mq-deadline consider sync writes as async requests and only > reserve tags for sync reads by async_depth, however, kyber doesn't > consider sync writes as async requests for now. > > Consider the case there are lots of dirty pages, and user use fsync to > flush dirty pages. In this case sched_tags can be exhausted by sync writes > and sync reads can stuck waiting for tag. Hence let kyber follow what > mq-deadline and bfq did, and unify async requests checking for all > elevators. > > Signed-off-by: Yu Kuai > Reviewed-by: Nilay Shroff > --- > block/bfq-iosched.c | 2 +- > block/blk-mq-sched.h | 5 +++++ > block/kyber-iosched.c | 2 +- > block/mq-deadline.c | 2 +- > 4 files changed, 8 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich