From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796AbcFURYR (ORCPT ); Tue, 21 Jun 2016 13:24:17 -0400 Received: from mail-bn1on0068.outbound.protection.outlook.com ([157.56.110.68]:31168 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751928AbcFURYP (ORCPT ); Tue, 21 Jun 2016 13:24:15 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support To: Joerg Roedel References: <1465855611-10092-1-git-send-email-suravee.suthikulpanit@amd.com> <20160621135043.GJ28248@8bytes.org> <88650292-bb48-a54c-296e-8680bc839e39@amd.com> <20160621144645.GF11432@8bytes.org> CC: , , , , , From: Suravee Suthikulanit Message-ID: <41753411-5d2a-effe-d074-d633e3f5e23d@amd.com> Date: Tue, 21 Jun 2016 10:45:07 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160621144645.GF11432@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR05CA0070.namprd05.prod.outlook.com (10.141.20.40) To BLUPR12MB0433.namprd12.prod.outlook.com (10.162.92.139) X-MS-Office365-Filtering-Correlation-Id: 81065f60-bf11-4ed8-7a17-08d399eb06ff X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;2:aoL9AS+M81b9hwKoyIHvFhRh4sIantUzgjGiIHS0nz8lZZm9jzu0e+pzyXd4ZU2FRF7JBpGbkgYK7jTYgkluqrPgHEzIE5kG06Z9rAXjpBK+lKaHD9BfNdlawxNMdWH0c33fsffLz6IZzP8kVhAEfOrFOWfnLNkbnjfelbaMHAyYVdEKP+bsEBrZxHn7nIbg;3:/FRohp91MHU+6bIgy1sJ5FyrFtKrq9haSWvexVKQX2cOV2WiO/hlk1wIkrWrKeJc+EaQm76uMPYvx+9oSKEYUmW0E67XYq4QtDCmECrTVHejoGAhEYz6fmpSoFDF7WDl;25:BZ75A7NY6YVVh897a2QfMFX1JeqKRMchrQZoXQ4IJZQq+STeds6lwbJJVyHvNXVZ8m2dWcoYaAA/WIc6IxArek5YaQjFyFiHrkJzy1tZ4xBWTOnHn5owE7qhFFz5dmmAivDKwRrF8bTswwEKQSJg7/guL4j50tpt6srj+gp6lihgRDyyiuy2M2PjC5Fq/VwFttchfx0dSeO5g09U5/cqOhtOKXYMUwojLqOjbv/R/pqoH1p4QAY3irvb+654QB0d8LW6CE6JVE0EDmYT9tnOg0cMPMtMMO9nNuapWA9cALAR/TxAyKhfein4ibobb28ePFowee8GfEYi/959Hdk19kvGahWk240ugAt5uqcpP9ntdQ9znUICHASfMl2k0CmgO5FkxrQKJXc59KnvINacJr1yOuakYbDz4qKjc0KXCHw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0433; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;20:tHOhQV1UGDCtJnVfRNISd3BioVpr5f2bmcM7WPpWEzTwBaqXJmCu61g8pTsjN5hkpgtBkH1NCqijYcOv3W5hNIfNvEc6GVjw/1Qrjv3Fe0r9RFxcWnYErvC+h4kMt5I/eX3hhGgZYwnROHSD6bSyihWLnwmGRfGEXj8/2q4XGkANr2cva+QTsaxVxxXqxjR3LZAh9SlIl/G7QPy/kSUKql/h9Xw3SUFzU7MT5d2N+vtdOrnpY2DQG9CySxOy6ZENtQNacyunxpbh6huaKkguBXqD1kHBYhOfamH/y107GcI/3tZED+UrrkQNeJW4d5U87AWX6a/7lAs9MRYGWovt8lWavA4Hl6+dysd8xsKqtUkmOa2KbvIVDlOyoDr77GzBcDkzLOC/wXlg/WRcGPNlOhKJ+WIm23RPjJNOydTaGKMYwmnVL3fyHZca0d6c8OoSsP31NqoWDp987yGiA96+8Vfd2GKLRgFg6kXTJkuI+RScdcHZcDDwY1/y4PZl2G90;4:smk/tugG85buNnAA9hWJvgAX0mopMZ/uBhOSenYDfpqMJ4DoArQYazTTgYRf+CaMEb1zvY68twBS1tHp9VMUUReE/qyCY4CXFKo71LNTBochQ00Nqgz1D2/GeU5GS+Hmb9fvoYEIqKIJeYrV0s4WnIGr/b0gCiqAfDqx5PwJBj/7F+QpI9kBz9VOSO9wmptcpOLXp7iBD4v9FXyxCqVxwl8IiA1K/xUbXmbLtbcPFASwFLe/NBlIqgS9av/84+d6V2EedPyZ5fUSab3+KaK4BKV//uroVOSAilVy0PVCgwJTLfz9twkKyP5fE3UKZ80LckRI8fIHwrNQwBMg7l/rAovCEy2HFuwi4A4PBDZlZB2dIJxKXKv5OZuo/v10ABXf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BLUPR12MB0433;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0433; X-Forefront-PRVS: 098076C36C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(377454003)(199003)(24454002)(189002)(77096005)(2906002)(50986999)(68736007)(4326007)(93886004)(66066001)(33646002)(106356001)(31686004)(2950100001)(189998001)(7736002)(230700001)(36756003)(50466002)(42186005)(92566002)(64126003)(110136002)(47776003)(23746002)(105586002)(76176999)(83506001)(54356999)(31696002)(101416001)(81166006)(81156014)(6116002)(586003)(3846002)(86362001)(4001350100001)(8676002)(7846002)(65956001)(97736004)(65806001)(65826006)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0433;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0433;23:rwCxA3NJUj7MNZZd1lW8g3gs4i0tdHBWGtCvC?= =?Windows-1252?Q?MKCxKW+sgUBG+5/ca/vkUY3Nf9zKHdw6hhBxv5QqRYHUlt+UyHcn1QB/?= =?Windows-1252?Q?WKTyfUuounZb1U/Rc2kqMTpKTgOar3QR4R4aDZq+j6TnPOEu0d+vf77m?= =?Windows-1252?Q?OgPzl6MJiInxRSaHyS6g7yzfikCQCQjN5J36kbd+Rdf0E9blXB0gxIdi?= =?Windows-1252?Q?T8euSRHxfEflDBIexQu/q7wcyW14YVJvT9dZ3jPEbXBW6MfYFgcc+8lD?= =?Windows-1252?Q?bppwGY5xLOrj55VF5bBPu6Kj3TP4wHO2WKjb3f8TnhPPXxEea3Gdotla?= =?Windows-1252?Q?VP2JQPoynmt6r4YBy+myZMgyliYB0R6PXEC4vlVLlc2k/H5iIdylDOGY?= =?Windows-1252?Q?G8SYkHRKkR2/xlGNOCbW2tRTTzeKrnXAj5O7Ls9/jY36PWCAg8Z37DHn?= =?Windows-1252?Q?/tUyBKjar/cAy5muSPa6H2uyNIBgCVI10krAEvKKJBvF8nbRMaKvXSCL?= =?Windows-1252?Q?bRPde9XQ1FUEqG3h7xXLKoF0PEUIvACpJc5GA7Jb3PCNLG+QXeDdKVNq?= =?Windows-1252?Q?VVmFFwaFgsVp6vl36TRF5DuXDIOkzUeiL9TQkNMbe0NZahczLrsAKUTA?= =?Windows-1252?Q?l4toxgL3ceXCCuqhieDhvwZYa1lDlBu1PHhBOpxf6Xk6dxbimyoJrLYh?= =?Windows-1252?Q?oLCc/stHYekPSvuooG/RWbx5xIdCeYxKq8CHKomY5lOqvi12OFKzTeS4?= =?Windows-1252?Q?yErtUVWJboVsEFffXiV8wdunbRYV5AUxBcl3uzSPHRLtSHWe7w13JDTH?= =?Windows-1252?Q?nH5BlPo1XOJYNsZvNxBG7oXj5/rkb0UOiYlTs+gzkwA+GtbFIpqnZb9F?= =?Windows-1252?Q?B/dtbMIS8ax3rjN5fyCUR9oFY3NwkB+GqQ0dvLV5SDgwT4KYHl3B2I/m?= =?Windows-1252?Q?GIcRVPSxmGF7ugqwCyBZ/pgtkZTUu8ICWyAUetVeynnQuC7gzy7NzwTJ?= =?Windows-1252?Q?XYpc/Qhif7+To+0KteutHpzJ4grdejfk6EjhJMij3rmKH/4afNGbT+1r?= =?Windows-1252?Q?lwOD7WHJ6cGNxta4RQ1PO1/g+YKZxkWpwYt2flJPGHEuYbbO3DZ4FxvJ?= =?Windows-1252?Q?i8SiS++Z9GdRUkqIqNkqx2S827eGxWryY4NbA0c8jmoU7/M5yMYRlmOW?= =?Windows-1252?Q?TuAJj1KO25icgCmLZEBiQ+l9XtBDUo5/JTBM+yP/SQOJtr8SR5QIbbpq?= =?Windows-1252?Q?eHGiG0Nxmo2Zrh7T1JssyeRi8U6I95tMo/9o3OFL1VtkyBubP92dUQ3l?= =?Windows-1252?Q?lxqecW4760xr0NFhbDnB4WkqQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;6:Ejpe57SHPYur7C+q7DsAJYq/JLw5Yi0aNlkzxnogPy/xJYREz9YF3bxcm4y6hd4eXZQpD5ShwzdzREV4bt4PzD9HYfow1DPJUFtAT301ZNjVd4wT3ows53H0HrybJ9W/3/wG8/KvopyYFz0LR2Fy0xPB2TvaMVEbZ0+7tDe/Queh8TYUSezSNcVZEeLwTB2bJDDkxJVFL65jX9gInoiGL5bhEaVQH/Mti9YpftdZl7gIo+GucGeKeBfkvvuw1NEwT+anRjqoEjidzbbj3FLi/FHUMlWxq9/8kmfTTxZ96hUj0ohzfOp1fERH+T493LGCqlvllGJ6SATWerUO0YMgVQ==;5:sbFvHFbv9FKc48o2xIrmCicusvNV5AloL+wR+vvD11uCB2hrNfkM2U4JKlhgH3qwgHvFklDqVSBaHOiVqnw8wTLZM8r6ZDF45oP2a9SK4siW0CyXM4GH3gLrWNLoNv+sW+eFkL4nxIn9ptHuiD99bw==;24:SNkCwUup0bmpwAvSVYIEHl+ASG204FWfMEdXqW0oEYeDmdkT5kI6OJyJu6dvCQZE9BlMLHAY8sPAoIb1CEBfCrMrC5qYyWyVMd8iIij1lkU=;7:5EKwDUBgDivzCUgmzgI1GgWd4Gic3h8kztCM3YragNCzCzWVyE3evmQ16oVk+d2tckV9hGvvjwjI6wym9hrwWFEhj/5rl2S9M+o+lofASN9sRXadc6hLEAabf6izjW5qBeOd6/kvGw9+kA9Yoq+nHavp9zEtl7PcdwKq0a2Z+ZS9e+kQk9W5QbnxN13oM/UwdPVY8I8Sl3n8FVE1I3JecQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0433;20:plI8GuhS2n4BkfsVDB+eLClnOQPPLfcNEKkI8w226zVasPGTdL6bDqVaDYmW6C71J7i34JE57QoSqO1GUcliVd1QZ6mVdbBJ+ZNSqhlmPvNjtscQ97MrjpCQOKtwguNKghurEuyFntrDgB/+SSXHBVFJeJp56p3L8wJ7aIqu6+56zm2KNqmiMPcfeklDbBlecTLvuCOTqBvw4Hl/nH+553CGbUZBJa5T5+itSpcjuiRKntzeJVaXN+HzkV5f5lIC X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 15:45:09.9236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0433 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/21/2016 9:46 AM, Joerg Roedel wrote: > On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote: >> On 6/21/2016 8:50 AM, Joerg Roedel wrote: >>> The code has a few style issues (thing I'd implemented differently), but >>> it looks functional. >> >> Anything in particular that you think I should improve or/and change? > > One thing I noticed were all the if (small IRTE) ... else (big IRTE) > that would better be hidden behind function pointers. Also a few magic > numbers are in there that could be replaced by proper defines. > > > > Joerg > Ok, I'll clean up some more and send out the V3. Thanks, Suravee