From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAE1C25B06 for ; Sat, 6 Aug 2022 09:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241733AbiHFJhX (ORCPT ); Sat, 6 Aug 2022 05:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229798AbiHFJhU (ORCPT ); Sat, 6 Aug 2022 05:37:20 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D2F15808; Sat, 6 Aug 2022 02:37:19 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4M0HNg0gYhzlVsH; Sat, 6 Aug 2022 17:34:27 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 6 Aug 2022 17:37:14 +0800 Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 6 Aug 2022 17:37:13 +0800 Subject: Re: [PATCH v2 0/7] perf kwork: A couple of fixes according to review comments To: , , , , , , , , , CC: , , , References: <20220730030335.78203-1-yangjihong1@huawei.com> From: Yang Jihong Message-ID: <417639ef-5c98-35a6-0ec7-501c1a33475a@huawei.com> Date: Sat, 6 Aug 2022 17:37:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, PING. Regards, Jihong . On 2022/7/30 11:03, Yang Jihong wrote: > Some issues are fixed based on the comments of several reviewers: > 1. Add '--synth task' option for record (note from Namhyung) > 2. Replace hard-coded initialization of nr_tracepoints with ARRAY_SIZE macro (note from Namhyung) > 3. Fix spelling mistake: "PRINT_TIME_UNIT_MESC_WIDTH" -> "PRINT_TIME_UNIT_MSEC_WIDTH" (note from Namhyung) > 4. Fix spelling mistake: "Captuer" -> "Capture" (note from Colin) > 5. Add some {} for multiline for/if blocks (note from Arnaldo) > > Modifying based on the latest commit (9a0b36266f7a) at acme/perf/core: > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core > > Yang Jihong (7): > perf kwork: Add '--synth task' option for record > perf kwork: Replace hard-coded initialization of nr_tracepoints with > ARRAY_SIZE macro > perf kwork: Fix spelling mistake: "Captuer" -> "Capture" > perf kwork: Fix spelling mistake: "PRINT_TIME_UNIT_MESC_WIDTH" -> > "PRINT_TIME_UNIT_MSEC_WIDTH" > perf kwork: Strdup function name in workqueue_work_init > perf kwork: Expand capacity of bpf entries > perf kwork: Add some {} for multiline for/if blocks > > tools/perf/builtin-kwork.c | 67 +++++++++++++--------- > tools/perf/util/bpf_skel/kwork_trace.bpf.c | 2 +- > 2 files changed, 40 insertions(+), 29 deletions(-) >