Keith Owens wrote: > > > They may only be OK because the code is never run more than once. > Normal code that refers to data.*init and is run more than once is a > bug just waiting to bite you. > > Andrew - small fix for reference_init.pl, against 2.6.9-rc4. > > ------------------------------------------------------------ > > Treat .pci_fixup entries the same as .init code/data. > > Signed off by: Keith Owens > > Index: linux/scripts/reference_init.pl > =================================================================== > --- linux.orig/scripts/reference_init.pl Sat Aug 14 15:37:37 2004 > +++ linux/scripts/reference_init.pl Tue Oct 12 15:59:39 2004 > @@ -93,6 +93,8 @@ foreach $object (sort(keys(%object))) { > $from !~ /\.stab$/ && > $from !~ /\.rodata$/ && > $from !~ /\.text\.lock$/ && > + $from !~ /\.pci_fixup_header$/ && > + $from !~ /\.pci_fixup_final$/ && > $from !~ /\.debug_/)) { > printf("Error: %s %s refers to %s\n", $object, $from, $line); > } Keith, It looks like __param section references can also be safely ignored by 'reference_init.pl', since they are not discarded AFAIK. Or am I wrong about that one? Patch attached -- applies on top of yours. -- ~Randy