From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: andrea@novell.com, linux-kernel@vger.kernel.org
Subject: Re: ZONE_PADDING wastes 4 bytes of the new cacheline
Date: Thu, 21 Oct 2004 14:53:57 +1000 [thread overview]
Message-ID: <417740E5.9010903@yahoo.com.au> (raw)
In-Reply-To: <20041020213622.77afdd4a.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>> #if defined(CONFIG_SMP)
>>
>> > struct zone_padding {
>> > - int x;
>> > } ____cacheline_maxaligned_in_smp;
>> > #define ZONE_PADDING(name) struct zone_padding name;
>> > #else
>>
>> Perhaps to keep old compilers working? Not sure.
>
>
> gcc-2.95 is OK with it.
>
> Stock 2.6.9:
>
> sizeof(struct zone) = 1920
>
> With Andrea's patch:
>
> sizeof(struct zone) = 1536
>
> With ZONE_PADDING removed:
>
> sizeof(struct zone) = 1408
>
>
Wow. You'd probably still want pad1 because that seperates the
allocator and the scanner. It looks like temp/prev_priority
should be _above_ pad2, and possibly free_area should be above
pad1.
Don't know about all the stuff below pad3.
next prev parent reply other threads:[~2004-10-21 5:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 1:17 Andrea Arcangeli
2004-10-21 3:10 ` Nick Piggin
2004-10-21 4:36 ` Andrew Morton
2004-10-21 4:53 ` Nick Piggin [this message]
2004-10-21 10:51 ` Mikael Pettersson
2004-10-21 12:45 ` Andrea Arcangeli
2004-10-21 18:54 ` Adam Heath
2004-10-21 20:21 ` DaMouse
2004-10-21 21:24 ` Jon Masters
2004-10-22 10:09 ` DaMouse
2004-10-21 22:26 ` Nick Piggin
2004-10-21 22:45 ` Andrea Arcangeli
2004-10-22 0:34 ` Nick Piggin
2004-10-22 1:10 ` Andrea Arcangeli
2004-10-22 1:26 ` Andrew Morton
2004-10-22 2:55 ` Jesse Barnes
2004-10-22 3:38 ` Nick Piggin
2004-10-22 3:49 ` Jesse Barnes
2004-10-22 17:15 ` Andrea Arcangeli
2004-10-22 3:09 ` Nick Piggin
2004-10-22 3:26 ` Andrew Morton
2004-10-22 3:35 ` Nick Piggin
2004-10-22 17:13 ` Andrea Arcangeli
2004-10-22 17:07 ` Andrea Arcangeli
2004-10-22 15:50 ` Andrea Arcangeli
2004-10-22 3:02 ` Nick Piggin
2004-10-22 16:58 ` Andrea Arcangeli
2004-10-23 4:33 ` Nick Piggin
2004-10-23 9:59 ` Andrea Arcangeli
2004-10-23 10:22 ` Nick Piggin
2004-10-23 11:03 ` Andrea Arcangeli
2004-10-23 16:28 ` Nick Piggin
2004-10-25 12:44 ` Andrea Arcangeli
2004-10-25 12:49 ` Nick Piggin
2004-10-25 13:51 ` Andrea Arcangeli
2004-10-25 20:09 ` Robert White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417740E5.9010903@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=andrea@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome