From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbcF2PWP (ORCPT ); Wed, 29 Jun 2016 11:22:15 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54735 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbcF2PWN (ORCPT ); Wed, 29 Jun 2016 11:22:13 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, Wan Zongshun Subject: Re: [PATCH 2/6] ARM: dts: nuc900: Add nuc970 dts files Date: Wed, 29 Jun 2016 17:24:10 +0200 Message-ID: <4179493.MLDazV8SdP@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466851042-22239-3-git-send-email-vw@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <1466851042-22239-3-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:a1Q6REWkgKQzDwwyD4IX2uSs9rUS+FOdg4yqnb0z2DQRqfVC+KH sECrnK7Ti6z2VPvjIm45IkGIhO48MPq66moe2H8iJDVJBnuO12cyxwzI4xQpdSSqt6jrBFX Bq3Pgf3RBBS91123NK2/vRpDloolyKYf+/yrCQgK9QhFgp+J4gHUZOesw2aGvxee0BKnAuX CtyJg61i2HzWyXRpKkS1A== X-UI-Out-Filterresults: notjunk:1;V01:K0:mpKP2ze8xVY=:YyaQpqWNjfJzhaoZMykJ3n 3vMMG4qu/cdeh3FPXvQbw+ayu/2fJkrCvHkzYhfiD03Y0ZBMr/a4YJPLo320EalYNkSldLDAK hCqQL0pPQmPV7xGL3Wy5gEpe+s6V6vaX7apHSgCrJfwg9g4L4ReZaaZvmAVAJt8iRI0GmKBKR p78J+h+2fLb+w6QWn3EeXXuGycLV+vK7wvVn9hlMVUttASkoSLwNBy7pPoHvGHjzhjT8f7qEr JD+3h46VFVwbueb/Xtl+6/EeeKgtSxNuSOUa/3qUw7VaSrnPAxpXGTpOALUIKCPHKolpLQPPc 9URkKHi0ufInjjMMN2oQsLuGmcDk55QvEj55jL64gvE50wk38JRvkI/HGm8LHwZO2SyJ4qMwa 9N10TYS8PGzFPYGILiVa4DOpSrPFDU06vk5mzFTZdDD/8ij91UfkkI+gz8f3QKEAAqVAl4Cc8 xT2hk2Hsna0i3WiscmRZpc7vyLLGq3XL12hA45+wnTV8jWSFlRntUKkiZOyTTTkWzNgOUBfWT XWpeeE+bDfaPYWrEf3HKausEx8aY2pb8UfnI5L3FME3wAV8M1NmafzxFN9JuFBXyXIboJtCcs m+QLSj0el55+DVXeYUbHMkwVyCYOhok+wvOPahdvxBow4f+f3srg1E8jCwE6xCdLkf8eAsUPg NJLXmTqIAwGcefvzQRe0sZNZdA4gGp8j/tyh/lDM5AZFCts1m60psxLkQ+qbGWDLJ8YJw+a/E PpyPe8dYq2Pct+N1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 25, 2016 6:37:18 PM CEST Wan Zongshun wrote: > This patch is to add dts support for nuc970 platform. > > Signed-off-by: Wan Zongshun > --- > .../devicetree/bindings/arm/nuvoton/nuc970.txt | 30 +++ > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/nuc970-evb.dts | 20 ++ > arch/arm/boot/dts/nuc970.dtsi | 93 ++++++++ > include/dt-bindings/clock/nuc970-clock.h | 233 +++++++++++++++++++++ > 5 files changed, 377 insertions(+) I'd suggest splitting this into multiple patches: the binding, the dts files and the header. > +Boards with the NUC970 SoC shall have the following properties: > + > +Root node required properties: > +- compatible: Should be "nuvoton,nuc970evb", "nuvoton,nuc970" Better don't mention "nuvoton,nuc970evb", as that is the board specific identifier: we don't want to have to list every single board. > +Timer required properties: > +- compatible: Should be "nuvoton,tmr" > +- reg: Should contain registers location and length > +- interrupts: hwirq is direct mapping to irq number > +- clocks: phandle to input clock. > + > +Clock required properties: > +- compatible: Should be "nuvoton,clk" > +- reg: Should contain registers location and length > + > +Interrupt-controller required properties > +- compatible: Should be "nuvoton,aic" > +- reg: Should contain registers location and length > +- interrupt-cells: set to 1 > + > +GCR register required properties: > +- compatible: Should be "nuvoton,gcr" > +- reg: Should contain registers location and length These compatible strings are all very generic, and should contain the SoC name. > diff --git a/arch/arm/boot/dts/nuc970.dtsi b/arch/arm/boot/dts/nuc970.dtsi > new file mode 100644 > index 0000000..8a6c225 > --- /dev/null > +++ b/arch/arm/boot/dts/nuc970.dtsi > @@ -0,0 +1,93 @@ > +/* > + * Copyright 2016 Wan Zongshun > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +#include "skeleton.dtsi" > +#include > + > +/ { > + compatible = "nuvoton,nuc970evb", "nuvoton,nuc970"; > + > + interrupt-parent = <&aic>; > + > + aliases { > + serial0 = &uart0; > + }; > + > + memory { > + reg = <0x00000000 0x04000000>; > + }; Better split this into SoC-specific and board-specific contents, the aliases and memory should go into the board.dts file, along with the alias for the serial port. > + ahb@B0000000 { Don't capatilize the hexadecimal numbers. > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0xB0000000 0x9000>; > + ranges; A simple-bus should not have a 'reg' property. You can have a 'ranges' though, to translate the addresses in the child nodes. Arnd