mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.9-ac4] delkin_cb: one-liner fix
Date: Mon, 25 Oct 2004 22:50:19 -0400	[thread overview]
Message-ID: <417DBB6B.3030307@rtr.ca> (raw)

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Alan,

Here's a one-liner for delkin_cb in your latest 2.6.9-ac stream.
This ensures that pci_disable_device() is invoked when the
driver exits on failure to load.

Signed-off-by: Mark Lord <mlord@pobox.com>
-- 
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")

[-- Attachment #2: delkin-fix.patch --]
[-- Type: text/plain, Size: 389 bytes --]

--- linux-2.6.9-ac3-delkin/drivers/ide/pci/delkin_cb.c.orig	2004-10-21 21:44:45.000000000 -0400
+++ linux/drivers/ide/pci/delkin_cb.c	2004-10-25 22:45:32.000000000 -0400
@@ -83,6 +83,7 @@
 	rc = ide_register_hw(&hw, &hwif);
 	if (rc < 0) {
 		printk(KERN_ERR "delkin_cb: ide_register_hw failed (%d)\n", rc);
+		pci_disable_device(dev);
 		return -ENODEV;
 	}
 	pci_set_drvdata(dev, hwif);

                 reply	other threads:[~2004-10-26  3:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=417DBB6B.3030307@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome