From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v4 05/11] nvme{032,040}: Use runtime fio background jobs
Date: Thu, 18 May 2023 08:38:01 +0000 [thread overview]
Message-ID: <417e9772-d622-7d98-397a-7fec162f63a0@nvidia.com> (raw)
In-Reply-To: <eykbvi7lzhnbd6ft6cva6qu4lp5ryn3ha2fgigmao2553qm4bu@227ey5mv5ls5>
On 5/18/23 00:52, Daniel Wagner wrote:
> On Wed, May 17, 2023 at 04:40:52AM +0000, Chaitanya Kulkarni wrote:
>> On 5/11/23 07:09, Daniel Wagner wrote:
>>> The fio jobs are supposed to run long in background during the test.
>>> Instead relying on a job size use explicit runtime for this.
>>>
>>> Signed-off-by: Daniel Wagner <dwagner@suse.de>
>> Is there any issue with the exiting approach for this change ?
> The expectation of the test here is that there is a background job running.
> Depending on the job size is an indirect way to express run at least for x
> seconds. This gives a variable runtime as it depends the how fast fio jobs gets
> executed. Explicitly telling the runtime is my opinion more robust and documents
> the indention better.
agree, it is better to kill on rely on the variable while test is
running ...
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-05-18 8:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 14:09 [PATCH blktests v4 00/11] nvme testsuite runtime optimization Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 01/11] nvme/rc: Auto convert test device size info Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 02/11] nvme{014/015}: Do not hard code device size for dd test Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 03/11] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 04/11] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-17 4:37 ` Chaitanya Kulkarni
2023-05-11 14:09 ` [PATCH blktests v4 05/11] nvme{032,040}: Use runtime fio background jobs Daniel Wagner
2023-05-17 4:40 ` Chaitanya Kulkarni
2023-05-18 7:52 ` Daniel Wagner
2023-05-18 8:38 ` Chaitanya Kulkarni [this message]
2023-05-11 14:09 ` [PATCH blktests v4 06/11] Documentation: Add info on nvme_trtype Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 07/11] nvme: Make test image size configurable Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 08/11] nvme: Add minimal test image size requirement Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 09/11] nvme{045,047}: Calculate IO size for random fio jobs Daniel Wagner
2023-05-17 4:44 ` Chaitanya Kulkarni
2023-05-19 1:36 ` Shinichiro Kawasaki
2023-06-01 8:46 ` Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 10/11] nvme{002,030}: Move discovery generation counter code to rc Daniel Wagner
2023-05-13 10:27 ` Chaitanya Kulkarni
2023-05-11 14:09 ` [PATCH blktests v4 11/11] nvme{016,017}: Make the number iterations configurable Daniel Wagner
2023-05-25 23:59 ` [PATCH blktests v4 00/11] nvme testsuite runtime optimization Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417e9772-d622-7d98-397a-7fec162f63a0@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®