From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: "Doug Anderson" <dianders@chromium.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"Aravind Venkateswaran (QUIC)" <quic_aravindh@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad
Date: Thu, 5 May 2022 10:20:49 -0700 [thread overview]
Message-ID: <4186ab8f-d227-f2c7-ab3f-0729bb915f17@quicinc.com> (raw)
In-Reply-To: <CAD=FV=XzGOGc8pMics4=idQeCuLYWxj=bHcic4NZa9+3qbqpbg@mail.gmail.com>
Hi Doug
On 5/5/2022 8:44 AM, Doug Anderson wrote:
> Ville,
>
> On Tue, Apr 26, 2022 at 11:47 AM Douglas Anderson <dianders@chromium.org> wrote:
>>
>> As per Displayport spec section 5.2.1.2 ("Video Timing Format") says
>> that all detachable sinks shall support 640x480 @60Hz as a fail safe
>> mode.
>>
>> A DP compliance test expected us to utilize the above fact when all
>> modes it presented to the DP source were not achievable. It presented
>> only modes that would be achievable with more lanes and/or higher
>> speeds than we had available and expected that when we couldn't do
>> that then we'd fall back to 640x480 even though it didn't advertise
>> this size.
>>
>> In order to pass the compliance test (and also support any users who
>> might fall into a similar situation with their display), we need to
>> add 640x480 into the list of modes. However, we don't want to add
>> 640x480 all the time. Despite the fact that the DP spec says all sinks
>> _shall support_ 640x480, they're not guaranteed to support it
>> _well_. Continuing to read the spec you can see that the display is
>> not required to really treat 640x480 equal to all the other modes. It
>> doesn't need to scale or anything--just display the pixels somehow for
>> failsafe purposes. It should also be noted that it's not hard to find
>> a display hooked up via DisplayPort that _doesn't_ support 640x480 at
>> all. The HP ZR30w screen I'm sitting in front of has a native DP port
>> and doesn't work at 640x480. I also plugged in a tiny 800x480 HDMI
>> display via a DP to HDMI adapter and that screen definitely doesn't
>> support 640x480.
>>
>> As a compromise solution, let's only add the 640x480 mode if:
>> * We're on DP.
>> * All other modes have been pruned.
>>
>> This acknowledges that 640x480 might not be the best mode to use but,
>> since sinks are _supposed_ to support it, we will at least fall back
>> to it if there's nothing else.
>>
>> Note that we _don't_ add higher resolution modes like 1024x768 in this
>> case. We only add those modes for a failed EDID read where we have no
>> idea what's going on. In the case where we've pruned all modes then
>> instead we only want 640x480 which is the only defined "Fail Safe"
>> resolution.
>>
>> This patch originated in response to Kuogee Hsieh's patch [1].
>>
>> [1] https://lore.kernel.org/r/1650671124-14030-1-git-send-email-quic_khsieh@quicinc.com
>>
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> ---
>>
>> drivers/gpu/drm/drm_probe_helper.c | 26 +++++++++++++++++++++-----
>> 1 file changed, 21 insertions(+), 5 deletions(-)
>
> I think this patch is fairly safe / non-controversial, but someone
> suggested you might have an opinion on it and another patch I posted
> recently [1] so I wanted to double-check. Just to be clear: I'm hoping
> to land _both_ this patch and [1]. If you don't have an opinion,
> that's OK too.
>
> Abhinav: I think maybe you're happy with this now? Would you be
> willing to give a Reviewed-by?
Yes, I have no concerns with this approach from DP spec standpoint and
in addition, kuogee has tested this out and this does help us to pass
the tests.
Although, I might be missing some historical context on why this is not
already done.
But apart from that, LGTM. Hence,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
> [1] https://lore.kernel.org/r/20220426132121.RFC.1.I31ec454f8d4ffce51a7708a8092f8a6f9c929092@changeid
>
> -Doug
next prev parent reply other threads:[~2022-05-05 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 18:46 [PATCH 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() Douglas Anderson
2022-04-26 18:46 ` [PATCH 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad Douglas Anderson
2022-04-26 19:16 ` Abhinav Kumar
2022-04-26 19:20 ` Abhinav Kumar
2022-04-26 20:26 ` Doug Anderson
2022-04-26 21:11 ` Abhinav Kumar
2022-04-26 21:17 ` Doug Anderson
2022-04-27 21:24 ` Kuogee Hsieh
2022-04-26 19:45 ` Doug Anderson
2022-05-05 15:44 ` Doug Anderson
2022-05-05 17:20 ` Abhinav Kumar [this message]
2022-05-05 17:30 ` Kuogee Hsieh
2022-05-05 20:11 ` Dmitry Baryshkov
2022-05-05 20:13 ` Dmitry Baryshkov
2022-04-26 22:21 ` [PATCH 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() Abhinav Kumar
2022-05-05 18:34 ` Thomas Zimmermann
2022-05-05 19:46 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4186ab8f-d227-f2c7-ab3f-0729bb915f17@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@linux.ie \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aravindh@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®