From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbcDRSdw (ORCPT ); Mon, 18 Apr 2016 14:33:52 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:64181 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbcDRSdu (ORCPT ); Mon, 18 Apr 2016 14:33:50 -0400 From: Arnd Bergmann To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Daniel Borkmann , Ken-ichirou MATSUZAWA , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code Date: Mon, 18 Apr 2016 20:33:15 +0200 Message-ID: <4187960.DvZepuNvUx@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160418181659.GA2427@salvia> References: <1460837916-1241019-1-git-send-email-arnd@arndb.de> <20160418181659.GA2427@salvia> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:PouC8bZxvrV5RmdfXnqaBS4ywMU6XfYoMR6wQKWcNezUliF/pEy 6wg+a6pfYJ/MbgQ2pI4l7B2x+2l3+LDc7eN3XxqwyPo4ZPTBMFmbXipHHFsEKal6r7dj9Av RQRaFwzsqfOf+kWzeRHx+ueFGnYOkaAybHoeUQH+AJOoMzYuIcozl5nrejLNt6v0NtWgHo7 vS0NdFq8bcpR56pvYyTyQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yuzGgc8BXvM=:3aCotjl+1nulObvWfLxAA0 fjfFwdFpNIAKuB7vLczS5koUZJXP6w7HbBJWUdc6gP+9MvfO63aaBrTtau7Gd0B+QovYgl9Q8 L6U0iX4eLRYxLeTG5H0oRooaGN3YjxUsPJsFUktKQq2T1pD2hR/FRFm1O+2WcTRQ4AN7VttQT tEXy4rmQCG86CbS23g/xOR5WfkGkyimyVfNrFii9pJG3TACmAEFi9KAqHP7f7CwNOIMb+T4IJ 5WhU7vWzst8dsXwTKnKlnRtZZ03OJ41KAesP7orfc8s+bSA6ryVWq4WokQ0WrEXkM9jZwthSu BskAPXocrGeCWsCWcT9wz5puj1jhWyH/2l8Y2K95Q8g6+qve9811QPJcRkwZYrOBKu7WJcFCB /TE8HyuSHh8Z+MTMKSHVadGlC7Hm+9rS7zQhp51niNX75jk7NIk0fjVlwOxbWoNa/eddsx3Gf n4B8QpazqJv6C+NZ84SAUWKMFfqr4xrtfRfAcATCqzHBcniagQqv4sLBqjl3sMpPu9olvqpiF 4zmjiBS1/q8iEJUeoU9aJpzKqmxX7Hha8V7FILPZgwIx1+UI8QnWOYr/C1swuultQX8T6BWa4 uBxhgFu1VKrShVgYZzi+dzMZZDLWpQW1xhzbNl9vvJNizSt0//cFN0S4Vbv7MQotMqjNIUGnm W2Lql4QwAVDTqPy3czqxqfJ0SsEATYpTebZrhU5+zk0GymryQmn63BA5vGENEwta64EmwPaBB +xENb2XJdW+yS+gM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > > A recent patch removed many 'inline' annotations for static > > functions in this file, which has caused warnings for functions > > that are not used in a given configuration, in particular when > > CONFIG_NF_CONNTRACK_EVENTS is disabled: > > > > nf_conntrack_netlink.c:572:15: 'ctnetlink_timestamp_size' defined but not used > > nf_conntrack_netlink.c:546:15: 'ctnetlink_acct_size' defined but not used > > nf_conntrack_netlink.c:339:12: 'ctnetlink_label_size' defined but not used > > Arnd, thanks for the fix. > > I'm planning to push this though: > > http://patchwork.ozlabs.org/patch/610820/ > > This is restoring the inlines for the size calculation functions, but > I think that's ok. They are rather small and they're called from the > event notification path (ie. packet path), so the compiler just place > them out of the way when not needed and we calm down the gcc warning. Looks good. I'll put this in my randconfig builder to replace my own patch and will let you know if you missed something. Arnd