From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: sata_highbank: Remove unnecessary print function dev_err()
Date: Tue, 9 Nov 2021 09:01:16 +0900 [thread overview]
Message-ID: <418b3bdf-42df-c7aa-0e21-fa35484a6931@opensource.wdc.com> (raw)
In-Reply-To: <20211105015021.38998-1-vulab@iscas.ac.cn>
On 2021/11/05 10:50, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/ata/sata_highbank.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 8440203e835e..b29d3f1d64b0 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq\n");
> + if (irq < 0)
> return irq;
> - }
> if (!irq)
> return -EINVAL;
>
>
Applied. Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2021-11-09 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 1:50 Xu Wang
2021-11-09 0:01 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418b3bdf-42df-c7aa-0e21-fa35484a6931@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®