From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FDAC7EE26 for ; Tue, 23 May 2023 20:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238291AbjEWUhj (ORCPT ); Tue, 23 May 2023 16:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjEWUhh (ORCPT ); Tue, 23 May 2023 16:37:37 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A345DCA for ; Tue, 23 May 2023 13:37:35 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 97711320039A; Tue, 23 May 2023 16:37:31 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 23 May 2023 16:37:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684874251; x=1684960651; bh=k+ bwdQP9AGCGHKD++qZv5KMOabdeJ0JpVksfMHT8xqQ=; b=g60/YYiE2JmkqOBOUa XY1qnShfctdB+wEArZbQpSLhHcZyqwcCUMjwHTqw05t3g63Ymx7kfjiWEWM4ryH/ QX67pkxSCtd9+iz3hQiaK0cIZH7EgJrbYd7L76Bu1iFroFmygo0oEt8DgU4AuX+Q y0S9gr8VYvoB6OZsxufVjAACGbFGmjYbMPQiyoj+JPlNRtjZpgp6rzYQWEvUa6C/ W0XhB4M8rRm70IfJaO1VtTNVT6kpM4800mHA5rfCrrbwPN8hGvRNdZvCVkV9ZwwA lq+Wuuqd0xmxskSyzlPCTuRhiK+pmfFMKhqQVMTQxOdxleMO0P18kkIY5rpD+g3D AFZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684874251; x=1684960651; bh=k+bwdQP9AGCGH KD++qZv5KMOabdeJ0JpVksfMHT8xqQ=; b=JDyznUMubiXFh8oJaXvwlfxCJWNSa PnVs/XoD3hYJrb3FGcvkxKqbR7sWjQHwDk0eKf4k+BT8Z7a6wlYllN8yA20PcF67 tYTUDjSPg04DOX5pYPGpYmFCC9tlQ9J8wme85X/WqSRyjynju0aR/z0fZEKk1btg nVdrIBtwvzImpuiE5xcpIQu0Or6pOI+inTFy34eCXWbhehA5hUoLQEkgGWIvaCJj UKyEnH5zn8Nm8VZ/B8aj3rduZZ7VFhvvKIVGZ03ldiXT6k+ubie3SxCcXFWPCZNj av+T6vdP6Vfd+hhThCeuoW+iPXSE9TtB3eB4tE2OZsYkXvQG5tExZncXQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejfedgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id BE89CB60086; Tue, 23 May 2023 16:37:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: <418f75d5-5acb-4eba-96a5-5f9ec7f963a6@app.fastmail.com> In-Reply-To: <35c82bbd-4c33-05da-1252-6eeec946ea22@oracle.com> References: <20230519092905.3828633-1-arnd@kernel.org> <35c82bbd-4c33-05da-1252-6eeec946ea22@oracle.com> Date: Tue, 23 May 2023 22:37:09 +0200 From: "Arnd Bergmann" To: "Boris Ostrovsky" , "Arnd Bergmann" , "Juergen Gross" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "Stefano Stabellini" Cc: "H. Peter Anvin" , "Oleksandr Tyshchenko" , "Peter Zijlstra" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] x86: xen: add missing prototypes Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2023, at 00:24, Boris Ostrovsky wrote: > On 5/19/23 5:28 AM, Arnd Bergmann wrote: > >> diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h >> index 22fb982ff971..81a7821dd07f 100644 >> --- a/arch/x86/xen/smp.h >> +++ b/arch/x86/xen/smp.h >> @@ -1,7 +1,11 @@ >> /* SPDX-License-Identifier: GPL-2.0 */ >> #ifndef _XEN_SMP_H >> >> +void asm_cpu_bringup_and_idle(void); >> +asmlinkage void cpu_bringup_and_idle(void); > > These can go under CONFIG_SMP Not sure if there is much point for the second one, since it's only called from assembler, so the #else path is never seen, but I can do that for consistency if you like. I generally prefer to avoid the extra #if checks when there is no strict need for an empty stub. I guess you also want me to add the empty stubs for the other functions that only have a bit in #ifdef but not #else then? >> +void xen_force_evtchn_callback(void); > > These ... > >> +pteval_t xen_pte_val(pte_t pte); >> +pgdval_t xen_pgd_val(pgd_t pgd); >> +pte_t xen_make_pte(pteval_t pte); >> +pgd_t xen_make_pgd(pgdval_t pgd); >> +pmdval_t xen_pmd_val(pmd_t pmd); >> +pmd_t xen_make_pmd(pmdval_t pmd); >> +pudval_t xen_pud_val(pud_t pud); >> +pud_t xen_make_pud(pudval_t pud); >> +p4dval_t xen_p4d_val(p4d_t p4d); >> +p4d_t xen_make_p4d(p4dval_t p4d); >> +pte_t xen_make_pte_init(pteval_t pte); >> +void xen_start_kernel(struct start_info *si); > > > ... should go under '#ifdef CONFIG_XEN_PV' What should the stubs do here? I guess just return the unmodified value? Arnd