From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH] little schedule() cleanup: use cached current value
Date: Tue, 09 Nov 2004 14:45:27 +0300 [thread overview]
Message-ID: <4190ADD7.CE7EFB7C@tv-sign.ru> (raw)
Hello.
schedule() can use prev/next instead of get_current().
Oleg.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.10-rc1/kernel/sched.c~ 2004-11-08 19:43:29.000000000 +0300
+++ 2.6.10-rc1/kernel/sched.c 2004-11-08 22:52:26.547195920 +0300
@@ -2508,7 +2508,7 @@ need_resched:
* The idle thread is not allowed to schedule!
* Remove this check after it has been exercised a bit.
*/
- if (unlikely(current == rq->idle) && current->state != TASK_RUNNING) {
+ if (unlikely(prev == rq->idle) && prev->state != TASK_RUNNING) {
printk(KERN_ERR "bad: scheduling from the idle thread!\n");
dump_stack();
}
@@ -2531,8 +2531,8 @@ need_resched:
spin_lock_irq(&rq->lock);
- if (unlikely(current->flags & PF_DEAD))
- current->state = EXIT_DEAD;
+ if (unlikely(prev->flags & PF_DEAD))
+ prev->state = EXIT_DEAD;
/*
* if entering off of a kernel preemption go straight
* to picking the next task.
@@ -2636,7 +2636,7 @@ switch_tasks:
} else
spin_unlock_irq(&rq->lock);
- reacquire_kernel_lock(current);
+ reacquire_kernel_lock(next);
preempt_enable_no_resched();
if (unlikely(test_thread_flag(TIF_NEED_RESCHED)))
goto need_resched;
next reply other threads:[~2004-11-09 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 11:45 Oleg Nesterov [this message]
2004-11-09 12:45 ` Ingo Molnar
2004-11-09 14:27 ` Oleg Nesterov
2004-11-09 15:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4190ADD7.CE7EFB7C@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®