From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, Blaisorblade <blaisorblade_spam@yahoo.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UML - signal bug fix
Date: Thu, 11 Nov 2004 19:09:50 +0100 [thread overview]
Message-ID: <4193AAEE.1000800@fujitsu-siemens.com> (raw)
In-Reply-To: <200411111957.iABJvHPV004137@ccure.user-mode-linux.org>
Jeff Dike wrote:
> This patch fixes a bug introduced in the last batch of signal fixes. The
> system call return value should only be reset if called diectly from a system
> call, i.e. sigsuspend. The fixes added earlier caused any interrupted non-zero
> system call return to be reset, confusing fork and vfork, among others.
>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>
Yes. The patchset was wrong.
But IMHO the solution shouldn't be resetting to the old state, that did syscall
restarting wrong!
The problem, you fix here, doesn't occur, when using my complete patchset. And my
patches fix UML's wrong syscall restart handling. And other issues they fix, too.
Bodo
next prev parent reply other threads:[~2004-11-11 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 19:57 Jeff Dike
2004-11-11 18:09 ` Bodo Stroesser [this message]
2004-11-12 1:09 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4193AAEE.1000800@fujitsu-siemens.com \
--to=bstroesser@fujitsu-siemens.com \
--cc=akpm@osdl.org \
--cc=blaisorblade_spam@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome