From: "Hans Verkuil" <hverkuil@xs4all.nl>
To: "Alexey Dobriyan" <adobriyan@sw.ru>
Cc: akpm@osdl.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org, hverkuil@xs4all.nl
Subject: Re: [PATCH] ivtv: don't recompile needlessly
Date: Tue, 17 Jul 2007 14:03:46 +0200 (CEST) [thread overview]
Message-ID: <4194.194.196.35.3.1184673826.squirrel@webmail.xs4all.nl> (raw)
In-Reply-To: <20070717114741.GC25083@localhost.sw.ru>
> Driver prints 3l33t banner including kernel version.
> Could we _please_ never do this in future.
Thanks for reporting this. This was a leftover from when the driver was
standalone. I've merged this patch in my repository and will push it
upstream.
Regards,
Hans
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> drivers/media/video/ivtv/ivtv-driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/media/video/ivtv/ivtv-driver.c
> +++ b/drivers/media/video/ivtv/ivtv-driver.c
> @@ -56,7 +56,6 @@
> #include "ivtv-gpio.h"
> #include "ivtv-yuv.h"
>
> -#include <linux/vermagic.h>
> #include <media/tveeprom.h>
> #include <media/v4l2-chip-ident.h>
>
> @@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {
> static int module_start(void)
> {
> printk(KERN_INFO "ivtv: ==================== START INIT IVTV
> ====================\n");
> - printk(KERN_INFO "ivtv: version %s (" VERMAGIC_STRING ") loading\n",
> IVTV_VERSION);
> + printk(KERN_INFO "ivtv: version %s loading\n", IVTV_VERSION);
>
> memset(ivtv_cards, 0, sizeof(ivtv_cards));
>
>
>
next prev parent reply other threads:[~2007-07-17 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 11:47 Alexey Dobriyan
2007-07-17 12:03 ` Hans Verkuil [this message]
2007-07-17 15:26 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4194.194.196.35.3.1184673826.squirrel@webmail.xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®