From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933021AbbDGX1f (ORCPT ); Tue, 7 Apr 2015 19:27:35 -0400 Received: from mga09.intel.com ([134.134.136.24]:59921 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933007AbbDGX1b convert rfc822-to-8bit (ORCPT ); Tue, 7 Apr 2015 19:27:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,540,1422950400"; d="scan'208";a="676649373" From: "Patil, Kiran" To: Kamal Mostafa , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "kernel-team@lists.ubuntu.com" CC: Dan Carpenter , Nicholas Bellinger Subject: RE: [PATCH 3.13.y-ckt 136/156] tcm_fc: missing curly braces in ft_invl_hw_context() Thread-Topic: [PATCH 3.13.y-ckt 136/156] tcm_fc: missing curly braces in ft_invl_hw_context() Thread-Index: AQHQcYWlPNrf1y8u2Ei/SWSWZBghuJ1CMEkw Date: Tue, 7 Apr 2015 23:27:29 +0000 Message-ID: <4197C471DCF8714FBA1FE32565271C148DD3E403@ORSMSX103.amr.corp.intel.com> References: <1428447093-3282-1-git-send-email-kamal@canonical.com> <1428447093-3282-137-git-send-email-kamal@canonical.com> In-Reply-To: <1428447093-3282-137-git-send-email-kamal@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NO OBJECTION. Good catch. My bad : Original patch which I submitted introduced this error. Thanks, -- Kiran P. -----Original Message----- From: Kamal Mostafa [mailto:kamal@canonical.com] Sent: Tuesday, April 7, 2015 3:51 PM To: linux-kernel@vger.kernel.org; stable@vger.kernel.org; kernel-team@lists.ubuntu.com Cc: Dan Carpenter; Patil, Kiran; Nicholas Bellinger; Kamal Mostafa Subject: [PATCH 3.13.y-ckt 136/156] tcm_fc: missing curly braces in ft_invl_hw_context() 3.13.11-ckt19 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit d556546e7ecd9fca199df4698943024d40044f8e upstream. This patch adds a missing set of conditional check braces in ft_invl_hw_context() originally introduced by commit dcd998ccd when handling DDP failures in ft_recv_write_data() code. commit dcd998ccdbf74a7d8fe0f0a44e85da1ed5975946 Author: Kiran Patil Date: Wed Aug 3 09:20:01 2011 +0000 tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data Signed-off-by: Dan Carpenter Cc: Kiran Patil Signed-off-by: Nicholas Bellinger Signed-off-by: Kamal Mostafa --- drivers/target/tcm_fc/tfc_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c index e415af3..c67d379 100644 --- a/drivers/target/tcm_fc/tfc_io.c +++ b/drivers/target/tcm_fc/tfc_io.c @@ -346,7 +346,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd) ep = fc_seq_exch(seq); if (ep) { lport = ep->lp; - if (lport && (ep->xid <= lport->lro_xid)) + if (lport && (ep->xid <= lport->lro_xid)) { /* * "ddp_done" trigger invalidation of HW * specific DDP context @@ -361,6 +361,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd) * identified using ep->xid) */ cmd->was_ddp_setup = 0; + } } } } -- 1.9.1