From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD605C433EF for ; Thu, 16 Sep 2021 11:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A58076124F for ; Thu, 16 Sep 2021 11:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237782AbhIPLZ6 (ORCPT ); Thu, 16 Sep 2021 07:25:58 -0400 Received: from smtprelay0119.hostedemail.com ([216.40.44.119]:40006 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S237745AbhIPLZy (ORCPT ); Thu, 16 Sep 2021 07:25:54 -0400 Received: from omf15.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 51539182CF666; Thu, 16 Sep 2021 11:24:31 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA id 1650DC4190; Thu, 16 Sep 2021 11:24:28 +0000 (UTC) Message-ID: <4197af5dfc99650e01bd4aacb776c5be9b795814.camel@perches.com> Subject: Re: [PATCH 3/7] staging: vchiq_arm: clarify multiplication expressions From: Joe Perches To: Gaston Gonzalez , linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Date: Thu, 16 Sep 2021 04:24:27 -0700 In-Reply-To: <20210915201824.413202-3-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> <20210915201824.413202-3-gascoar@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 544ueume7b44rqkoammscrdxq1p9crw3 X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 1650DC4190 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/jXw/7d8P9VGTIZTO9ZcXYXwOL860FHv4= X-HE-Tag: 1631791468-112681 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-09-15 at 17:18 -0300, Gaston Gonzalez wrote: > Add spaces around '*' in multiplication expressions to enhance > readability. [] > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c [] > @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) >   >   g_free_fragments = g_fragments_base; >   for (i = 0; i < (MAX_FRAGMENTS - 1); i++) { > - *(char **)&g_fragments_base[i*g_fragments_size] = > - &g_fragments_base[(i + 1)*g_fragments_size]; > + *(char **)&g_fragments_base[i * g_fragments_size] = > + &g_fragments_base[(i + 1) * g_fragments_size]; >   } >   *(char **)&g_fragments_base[i * g_fragments_size] = NULL; unrelated: These '*(char **)&' uses are odd and thankfully rare constructs.