From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbbJPWDo (ORCPT ); Fri, 16 Oct 2015 18:03:44 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56759 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbbJPWDm (ORCPT ); Fri, 16 Oct 2015 18:03:42 -0400 From: Arnd Bergmann To: Marcel Holtmann , Gustavo Padovan Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] bluetooth: bpa10x: fix BT_HCIUART dependency Date: Sat, 17 Oct 2015 00:03:38 +0200 Message-ID: <4199320.WWtqtXexhZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:G+z9AzOedRGAtzEGaa500RCPOjQxaW+UYUjFURkxuLil1pYbj1G blka/IuWhS6Ish2l0mN5p86s6vuzsdTTmEezfnhRWyqjiVYGsItR8j6eLXasBfR7EpR4dlW aUxOi22WonkZ+KAHDCyxNbGo2492WP1oWHJtf96QZQV2guROlsV7kacKynFdfJeTSUVhv4U ojWaIs2+UF8XqrNB7KM+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:1gOkRmOQ+Qw=:GcMGcVl8TBHFTyY0zbZn97 xfaOpbpc1+yOcvtmi9WUXgpBpIXTc8v6cn6lm5vkiWXzmLnpuvL1UpTMOOsQtBLcAD17Fasr3 LMUUONg7InKgORRJN76Lq1dfmkHaxcPXAA6ak2dRD44cJz+5UTqAJNqFZrjP9UHK9VXhb4nO7 yjTEQXtYTNT8QmWdF6r1soiSkh6GoMvmuWDvQyukREm22swax7fHJs8nK5eRmv1Rqm5Ru+YXo bOgZ5dfxUH+uMh4XTw21aQ1F7b2BobDz8ulv3zyFFaV30l7pkGktsojuqiOIja9k1aoN1aCFF wbTMm5YQdp9srXHClmSjrMCob8bsG+AELQrEQRMpVr2glLXnm6oVKJXD8EK0Pzs1oVVOtSMTn I/VLGoPrUJfxczHyYwfx9iVV+L7y1HHxZ5E3ljT0Vnuy8P8gTKYshqV7kuiugtSiYwt7Lo5Yk gLP71VEXU/UurX6ixXLqDxS3qwyQKQMByhOIGuNlm6Ikcre7lO5dt9tSUkDOhTcfFelQI80H1 HZLnzDPJr9UOm7srOepeubDktfjFU5PrDtCLYcy9OK9DR4vN4U+qu576yZ9G74UtSlqz7/tDJ 7T2cJB4mcb3QaZMr78hep8YeFk9YcVp8MUbpC2N6ZO70XNZyHFvfzZPqdu1PK72imdWGjWvfi Hpw6EVkilDoTV/PEPoWbSktcj1Bqge1OiW8vWEppzS+2faAkHnwZMfWX/3OywKvD4oooA9uTy toIfzgboXMAhZjT2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The change to bpa10x to use the h4_recv_buf helper added a dependency on BT_HCIUART. This was incorrectly added to Kconfig by adding a 'select' statement, which now in turn causes build failures when CONFIG_TTY is not set: warning: (BT_HCIBPA10X) selects BT_HCIUART which has unmet direct dependencies (NET && BT && TTY) vers/built-in.o: In function `hci_uart_tty_receive': fpga-mgr.c:(.text+0x282824): undefined reference to `tty_unthrottle' drivers/built-in.o: In function `hci_uart_tty_ioctl': fpga-mgr.c:(.text+0x282aa0): undefined reference to `n_tty_ioctl_helper' drivers/built-in.o: In function `hci_uart_flush': This replaces the 'select BT_HCIUART' dependency with 'depends on', which does not have this kind of problem. Alternatively, one could add 'depends on TTY', but avoiding 'select' on user-visible options is generally the preferred choice as that does not introduce the potential for dependency loops or incomplete dependency chains. Signed-off-by: Arnd Bergmann Fixes: a4a4affca68c ("Bluetooth: bpa10x: Fix missing BT_HCIUART dependency") Fixes: 943cc592195e ("Bluetooth: bpa10x: Use h4_recv_buf helper for frame reassembly") --- Found on ARM randconfig builds diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index fcf52fdb1ba3..ec6af1595062 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -183,8 +183,7 @@ config BT_HCIBCM203X config BT_HCIBPA10X tristate "HCI BPA10x USB driver" - depends on USB - select BT_HCIUART + depends on USB && BT_HCIUART select BT_HCIUART_H4 help Bluetooth HCI BPA10x USB driver.