From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F72D340293 for ; Sat, 30 May 2026 17:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780161517; cv=none; b=Lx/itoiHnclLYQFK/ivcECfTZvaNP8HRqae+iTqufiYXp2uofTwsDWUxZSuUWwnN5M6QBbUJmtqc1GvsQcIzE8f944xkaSGL0dRgRzj09AJsuHgOFFpRVnDi3dtkbSXxIP+vs824l9vfOzaMedPJrToYgjjuBcdn3ax0zQo6e2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780161517; c=relaxed/simple; bh=L/n8FthbOSu8XAf2UV+a3TPgwTIgRndmkwWixIDTI4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NRY68gXYQz5XgnBru794u6MAOdpWVsNjNMsoTx8GoJIOEDL7qmKujs8EsbVne44yLpxNnfVKMerFUTzGXuZXlUmVg0sy/sjolbCTLwNcSkBSM09uq3kMcoW/J3yw87wuDPtXtc2NONPk5t05xMPt2X9WT+aOFemrw8xKEiaZxm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TeeJShlp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TQWSIMSl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TeeJShlp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TQWSIMSl" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64UEOkEB250576 for ; Sat, 30 May 2026 17:18:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hyCgsZKUkbKisu6PZiCRW4u11DF6cixRx/fFwaOBVgM=; b=TeeJShlpyf9NBi7/ ulfWrsa/PqmDCNoM0ZIqsKIdnkAFdlrLK6sBtlu0E68aD8+/IA9B+N8DjKaZJBKL it76n6LVH9Hnv+cFjZGiMyltOUZLZ/XjpA4MymnICz+9mz4seIIR+x37MxUL9IpL OHAZ75mOmj2MkxBfCH0p+Ddoo7L9X0WY7SqL3TlRUUOcI2WFt6AHO0x5KQgfADlt tQeF31NkfZb9IP48MAGfJ1wg8sE9xukDcm0C4aJG4S9rsPtSjSHI3jochsoVD39+ jPlgr9Wnht1o41OE1geascPePcdcSLg6MYZMzts4pb52PbFp0lI/z1YSrkaoByEy 1PZhXQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efux5119x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 30 May 2026 17:18:35 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36d8719bae6so147301a91.3 for ; Sat, 30 May 2026 10:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780161515; x=1780766315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hyCgsZKUkbKisu6PZiCRW4u11DF6cixRx/fFwaOBVgM=; b=TQWSIMSlcIoU3g/4tlLDw5JxwOP052UtVUZx9iQMT++A/icNed0q9Nj4Ey6ZV00wj4 6I7/E3pmzh23pKx8zOpjAk4GKRKjr+dSXfXqLA5SHSlIdN7xbtxmSZX6EIMMq3guSXpr f8WMAr0xlAm8Ak2pCNAHY2+YE4YQxgMaJJ+A5gG8RgStDXXF9+txdYhbMYMcCXP39sE2 o43H9ARBeLgA4lv3PV5af+WFvbNiuAX75sjuoEsQzpwsgUlY4iVxJf5m9rNK54Qcj3qD xL80A2uEjSKHD2vxJzxtS5oGfLIsrryZ+KP11mUFr0RIJwm2nKvnM9YyxTR/OkslROg3 k7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780161515; x=1780766315; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hyCgsZKUkbKisu6PZiCRW4u11DF6cixRx/fFwaOBVgM=; b=J+0Qj3ief1o/VNavv5MU1u2DAAFpkYq45VG1PJA8nure7fPsjBSsUhCvq40vFZ8A42 T64cZWPGUgBByRAOtYDMW2UyvVNu6dr3nDnAW1Kg6vYgnEeEW77110Pr55AC1cpsK2b5 h5xDypN4WB035tNRr1nG0JRth14xYYc0A1k9b7CtoGIixop4n9e1qYxkKhaih1YPw1rc QJKaXLn1WG7EQPiyMKT8xDFZUdeCkvGBtt/k5Ug0+lBM4ZJwqyQcwmyBLh2xftzaQuTx /FY0pCLQpC4wXB7vvwH3SjwTP1aYW8O+5/Csq/rLrCJErl3MbKPulkEvatZo0YKnrEbL VEfg== X-Forwarded-Encrypted: i=1; AFNElJ9DWTkDAXU7Nsg528voht06+2Nj8HL/f+vpRzYAI/At/h4EU6W2106vjHyXxIJSe0cRKwxxfCe+eZz8xxM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv9riWMs+0+d2jPiLzDf4R5+0QGmAEQBV7/zoxLW05Ryf3ejdD sFOWW0GdKGh8DPHpjnwiiExYpsnXl7+IdQ7P/w8jNVnOf/qzaBroNh+zUODA/mM7pDi4fZG3TFr NQf4Kusp2SHUME0LEht2E4cgy1XwtIWW1wGXlMncqGmJTwqqugRm14AsLSUOSANM6UjE= X-Gm-Gg: Acq92OHPHax5hCeG0NikSuAp3hxQVJeV0r+PWOn6/pFw143WeXIxgePORUmsPy7MF3J BcE/lC8HRabD7v8E/zJm8jjPrmT6RE4DEK3rsR/q/2DdX2SgUnFGiHu17NOZ7DKiQoUYFmyZslE gvL3pFC01rVxoxoVHgnrD7IQgrw1K32EMXaruWR4xeh+IUEanD+XvUlvdkuC4uthyw//cBetA9n 1AAijSMk5Ek3WHnZ7HghsZfdomx2midEAPQQJ3Idzyzb/PGqOYeDq1oD7kkJSamKo5P7tlrKKNC eCvr950+2o7EeV8SA5wklXynhxizlx+Y378cQS+8t5Suf8m11GY0AWuPz2DAzjFjFP46vfs1/yK ie/xybcxyMfkBz3oCwls7XgJ77sZl3ehLtgGqQ9+tU2E8qxwahXjXmZJ0HBzG36tETbdRq26mer M9 X-Received: by 2002:a17:90b:580b:b0:36d:66d4:270e with SMTP id 98e67ed59e1d1-36d66d436cfmr2889912a91.5.1780161515023; Sat, 30 May 2026 10:18:35 -0700 (PDT) X-Received: by 2002:a17:90b:580b:b0:36d:66d4:270e with SMTP id 98e67ed59e1d1-36d66d436cfmr2889893a91.5.1780161514535; Sat, 30 May 2026 10:18:34 -0700 (PDT) Received: from [192.168.11.104] ([124.123.82.179]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc65e7afasm6873219a91.1.2026.05.30.10.18.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 May 2026 10:18:33 -0700 (PDT) Message-ID: <419a2eaa-7bf0-4a36-bc68-b769188613e0@oss.qualcomm.com> Date: Sat, 30 May 2026 22:48:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: allow peer_id 0 in dp peer lookup To: Hangtian Zhu , jjohnson@kernel.org Cc: ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260512025732.1297849-1-hangtian.zhu@oss.qualcomm.com> Content-Language: en-US From: Rameshkumar Sundaram In-Reply-To: <20260512025732.1297849-1-hangtian.zhu@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: JpkvsJnQMrJnzCau5qSoqPfzP_BP-2IE X-Proofpoint-ORIG-GUID: JpkvsJnQMrJnzCau5qSoqPfzP_BP-2IE X-Authority-Analysis: v=2.4 cv=BdnoFLt2 c=1 sm=1 tr=0 ts=6a1b1beb cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZCREz13nqshT/on6E9YcPw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=SnksKqQ5Byg3HTYQ0yEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMwMDE4NyBTYWx0ZWRfX3OlpQGnRJgij 6UTjRRK9gNF2+gD5741MJGIZHgqg/SvBGN2AppggXe7oCgeu4OI1GAN/E+Ivn62ULS8Y2wveQKq JSfl8AIeHPgSPacAbbzelu6dZQvbfpBKfZgfI0WzO/RfafVewwbW8nIpQo2T0JAIFLu95vQxeoC wXIcmSFGMbHpAOlXxslNQGh2uq8a/kIVerPjbeA3Bc/05OJBkenz5EuVuoZDjFoPh75yuwpgzzb VC+HAvLzZPG6vmej0xS5aTLloyWQIfjJfUzza0LE1wVXX3R/DbhurNJzfpLPkZRqHDieu9QVO6p b6LCgir3GYk7P2wQN4hWe3jnt8H/QmTNTfV6XQCcPNnWtAEst5cc8Am4mr5yIx/N3Qp/Y8uFO7r AwFLuPSmLvNjokUdUMs/5iPkF3thYCeUWaFP+Y8hW7wACVkpnxK7un82wqPQqOj/pr/SHfo275M V0jpqRB2UFOhez6VAaA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-30_05,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605300187 On 5/12/2026 8:27 AM, Hangtian Zhu wrote: > For some chipsets, firmware can report HTT_T2H_MSG_TYPE_PEER_MAP2 with > peer_id 0 as a valid value for mapping ath12k_dp_link_peer to > ath12k_dp_peer. > > ath12k_dp_peer_find_by_peerid() currently treats peer_id 0 as invalid. > When firmware assigns peer_id 0, peer lookup fails. As a result, > DHCP OFFER packets are dropped in __ieee80211_rx_handle_packet() > because pubsta is NULL. > > ath12k_dp_rx_deliver_msdu() <- rx_info->peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > ieee80211_rx_napi <- pubsta NULL > ieee80211_rx_list > __ieee80211_rx_handle_packet <- pubsta NULL, skb undelivered > > The following error in the TX completion path is caused by the same issue: > > ath12k_wifi7_pci 0000:04:00.0: dp_tx: failed to find the peer with peer_id 0 > > The error message is triggered by: > ath12k_wifi7_dp_tx_complete_msdu > ath12k_dp_link_peer_find_by_peerid <- ts->peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > > ath12k_dp_tx_htt_tx_complete_buf > ath12k_dp_link_peer_find_by_peerid <- peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > > Fix this by allowing peer_id 0 in ath12k_dp_peer_find_by_peerid() and > rejecting only values >= ATH12K_DP_PEER_ID_INVALID. > > Also update peer_id 0 handling in monitor path: > Always call ath12k_dp_link_peer_find_by_peerid() in > ath12k_dp_rx_h_find_link_peer() to fetch the peer, including when > peer_id is 0. > Always store peer_id in ppdu_info->peer_id in > ath12k_wifi7_dp_mon_rx_parse_status_tlv(), including peer_id 0. > > Tested-on: QCC2072 hw1.0 PCI WLAN.COL.1.0.c2-00074-QCACOLSWPL_V1_TO_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Hangtian Zhu Reviewed-by: Rameshkumar Sundaram