From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C894B1CF2AC for ; Thu, 10 Oct 2024 19:36:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728589012; cv=none; b=HVVpKK6HUeR5aJIPGyvInIhthkNuE4omiYrGrFgB2i9rpQXIcOKR0L2FJkNpkvoaIGKIqCJ8kqr4CPSdy7R+B6jRjVW3X84quzU9CyhTfujfuiL/4IFpLG5cr84EnoKJUfVxy4VoXxXAYIAo7euUi40D+GgdYdKgLo50KRGlKOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728589012; c=relaxed/simple; bh=LdH2ws4WUbLhEGUxo2Llnun/ISQsR/Y5CEoQqNDZ7Ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pjkQQC1JZpnVaLfh2dhyl3wrW03O9gWhCdozkcH96dpMu6W2jszJz6LUJ9axWb+Qzj0QM/+HJTK+TFdW8s1qQa5Kz+miBa0T4QvppSPjA4obQNEpsrcoRPhObQkTDs8MFMUmIZVr28m0cZLIJGIwBN8ZYxFR1S5k6966Cgz2OKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PL6rd8rX; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PL6rd8rX" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-8354851fcabso55533839f.2 for ; Thu, 10 Oct 2024 12:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728589010; x=1729193810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3EEjOsTCT982//p4qMynBPn2v7qBB0fVqK87z+caMTs=; b=PL6rd8rX9K2PD1eEYJpVnJwSN5wVEX7xMBJzM8xNFZXHb2XBGos36C1EIGGXrsxPGs oiOLcblJXBPj3hRWJ919KxYbQw10Qe3O/+CRxJy6LrB3Ob6hFAx3hBF3VZnGkExbXXdI dRKfRY8csXWO43OdhpkWH4v2wJhppoSfmiAIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728589010; x=1729193810; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3EEjOsTCT982//p4qMynBPn2v7qBB0fVqK87z+caMTs=; b=qjYinvHzulz3epnQi8U4qTZXFYH1bY/H3bi8bZfnItXikJZFrGhmXJrzCtQjwt2FJL vvLbvAR5yVcatekmKe5Cu/XF5a/SWC9o+3FW0IZIcRGjXYHUjMdqWYn+ZZExTDgRCKff HKHescaPMq4fCBhdeD7+WGdHQVj0kuvnjDHEmUl6hgKSE0UMyqAXU9b4Na6DZLNO8BJ/ vLqQtzsBLZJDxIie+f4yxJU4p6pccAKYpVHjkJqqH3bjnocEbeVauwjGotOU1lleu0Ky rGOARilntVm+Bz9vzWN94TnkTr5LXeGMkdaQQhuOC8KQPlfxJzUZA+Ugm2kYAis1vmC/ TcAg== X-Forwarded-Encrypted: i=1; AJvYcCVrwplp5yA5eHTBLjDBEhUoXUYTKFvMVlcFXtCWBbxrjVmkhsRwXEsP69EP2nirYQkzC1wjNdpkhIWancA=@vger.kernel.org X-Gm-Message-State: AOJu0YyM4j9mlopOk72Y1ZD8cBXL64JVybr5WUmT7+2tlZsKiRpUo4OG LrZvZFGEIXWX9VVWMbtN3tpj8jQge16gmWsXR+mdgfYHd5/X3ACQ///VzxVzIMk= X-Google-Smtp-Source: AGHT+IFJfagwlyeJRhazsQ8OzF3SbdndAdZV4keDYcnDHDKQVcvrg0LMNOheltT1enhrmGbkf/fLkw== X-Received: by 2002:a05:6602:2dd3:b0:82a:23b4:4c90 with SMTP id ca18e2360f4ac-83792703cd8mr9881039f.1.1728589009873; Thu, 10 Oct 2024 12:36:49 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbada84990sm359492173.113.2024.10.10.12.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 12:36:49 -0700 (PDT) Message-ID: <419dde21-7477-4eb2-92ab-7062414cfa0d@linuxfoundation.org> Date: Thu, 10 Oct 2024 13:36:48 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2][next] ASoC: rt722-sdca: Remove logically deadcode in rt722-sdca.c To: "Everest K.C." , oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241010175755.5278-1-everestkc@everestkc.com.np> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/24 13:35, Shuah Khan wrote: > On 10/10/24 11:57, Everest K.C. wrote: >> As the same condition was checked in inner and outer if statements. >> The code never reaches the inner else statement. >> Fix this by removing the logically dead inner else statement. >> >> Fixes: 7f5d6036ca00 ("ASoC: rt722-sdca: Add RT722 SDCA driver") >> Reported-by: Shuah Khan >> Closes: https://lore.kernel.org/all/e44527e8-b7c6-4712-97a6-d54f02ad2dc9@linuxfoundation.org/ >> Signed-off-by: Everest K.C. >> --- >> V1 -> V2: Added [next] tag >> > > You don't need next tag for this. This patch is in the mainline. Sorry meant to say this source file is in the mainline. You v1 is sufficient. thanks, -- Shuah