From: "C.Y.M" <syphir@syphir.sytes.net>
To: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: bt8xx cleanup
Date: Thu, 02 Dec 2004 06:21:40 -0800 [thread overview]
Message-ID: <41AF24F4.5040800@syphir.sytes.net> (raw)
Since you just applied those other cleanups from 2.6.10-rc2-bk15, here
is one more you might want to add. Thanks.
diff -Nru a/drivers/media/dvb/bt8xx/bt878.h
b/drivers/media/dvb/bt8xx/bt878.h
--- a/drivers/media/dvb/bt8xx/bt878.h 2004-10-20 08:19:52 -07:00
+++ b/drivers/media/dvb/bt8xx/bt878.h 2004-11-19 05:52:47 -08:00
@@ -102,7 +102,7 @@
unsigned char revision;
unsigned int irq;
unsigned long bt878_adr;
- unsigned char *bt878_mem; /* function 1 */
+ volatile void __iomem *bt878_mem; /* function 1 */
volatile u32 finished_block;
volatile u32 last_block;
@@ -129,17 +129,17 @@
void bt878_stop(struct bt878 *bt);
#if defined(__powerpc__) /* big-endian */
-extern __inline__ void io_st_le32(volatile unsigned *addr, unsigned val)
+extern __inline__ void io_st_le32(volatile unsigned __iomem *addr,
unsigned val)
{
__asm__ __volatile__("stwbrx %1,0,%2":"=m"(*addr):"r"(val),
"r"(addr));
__asm__ __volatile__("eieio":::"memory");
}
-#define bmtwrite(dat,adr) io_st_le32((unsigned *)(adr),(dat))
-#define bmtread(adr) ld_le32((unsigned *)(adr))
+#define bmtwrite(dat,adr) io_st_le32((adr),(dat))
+#define bmtread(adr) ld_le32((adr))
#else
-#define bmtwrite(dat,adr) writel((dat), (char *) (adr))
+#define bmtwrite(dat,adr) writel((dat), (adr))
#define bmtread(adr) readl(adr)
#endif
reply other threads:[~2004-12-02 14:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41AF24F4.5040800@syphir.sytes.net \
--to=syphir@syphir.sytes.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome