From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [BK PATCH] fix floppy build
Date: Wed, 29 Dec 2004 14:02:12 -0500 [thread overview]
Message-ID: <41D2FF34.3040606@pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
So my patch removing #include kernel/version.h broke the modular floppy
build... doh. I would prefer to remove the redundancy of listing the
kernel version each time the floppy driver is loaded.
See attached for 'bk pull' and example patch.
[-- Attachment #2: changelog.txt --]
[-- Type: text/plain, Size: 847 bytes --]
Please do a
bk pull bk://gkernel.bkbits.net/misc-2.6
This will update the following files:
drivers/block/floppy.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
through these ChangeSets:
<jgarzik@pobox.com> (04/12/29 1.2079)
block/floppy.c: fix build by removing UTS_RELEASE use
It's redundant to the kernel message that prints out the kernel version,
as well as many other places where one can request the kernel version.
diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c
--- a/drivers/block/floppy.c 2004-12-29 14:00:55 -05:00
+++ b/drivers/block/floppy.c 2004-12-29 14:00:55 -05:00
@@ -4595,7 +4595,7 @@
int init_module(void)
{
- printk(KERN_INFO "inserting floppy driver for " UTS_RELEASE "\n");
+ printk(KERN_INFO "inserting floppy driver\n");
if (floppy)
parse_floppy_cfg_string(floppy);
next reply other threads:[~2004-12-29 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-29 19:02 Jeff Garzik [this message]
2004-12-29 19:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D2FF34.3040606@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®