Leon2 serial+ethermac driver, updated. [7/7] diff2.6.10_driver_serial.diff: diff for drivers/serial Alan Cox wrote: > On Maw, 2005-01-04 at 19:04, Jiri Gaisler wrote: > >>+ if (tty->flip.count >= TTY_FLIPBUF_SIZE) { >>+ tty->flip.work.func((void *)tty); >>+ if (tty->flip.count >= TTY_FLIPBUF_SIZE) { >>+ printk(KERN_WARNING "TTY_DONT_FLIP set\n"); >>+ return; >>+ } > > > This code is broken. Please copy the fixes from the other > drivers/serial/*.c files as you've copied a bug from the reference code. > There are some other small cleanups in the base code that are worth > adding too in particular removing direct (ab)use of tty->flip. because > that will be changing some time in the future (when I finish debugging > the tty layer mess) > > > . > -- -------------------------------------------------------------------------- Gaisler Research, 1:a Långgatan 19, 413 27 Goteborg, Sweden, +46-317758650 fax: +46-31421407 email: info@gaisler.com, home page: www.gaisler.com --------------------------------------------------------------------------