From: Bradley Morgan <brads@mainlining.org>
To: atomlin@atomlin.com
Cc: akpm@linux-foundation.org, chjohnst@gmail.com,
david.laight.linux@gmail.com, lance.yang@linux.dev,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
mproche@gmail.com, neelx@suse.com, nick.lange@gmail.com,
pmladek@suse.com, sean@ashe.io, steve@abita.co
Subject: Re: [PATCH v10 2/2] hung_task: Log summary line when warning budget is exhausted
Date: Sat, 29 Aug 2026 16:22:31 +0100 [thread overview]
Message-ID: <41DC3C37-B2D8-4B74-BA05-87FCDFC20CBD@mainlining.org> (raw)
In-Reply-To: <20260829145321.18423-3-atomlin@atomlin.com>
On 29 August 2026 15:53:21 BST, Aaron Tomlin <atomlin@atomlin.com> wrote:
>Once the warning budget is exhausted, hung_task_info() normally stops
>printing per-task details. When panic is triggered, full details are
>still printed so diagnostics remain available before panic.
>
>To retain visibility without restoring per-task output after budget
>exhaustion, emit a single aggregate summary line at the end of each
>watchdog scan that detects hung tasks with an exhausted budget. This
>keeps non-panic per-task reports budgeted during system-wide hangs.
>
>Suggested-by: Petr Mladek <pmladek@suse.com>
>Suggested-by: Lance Yang <lance.yang@linux.dev>
>Reviewed-by: Petr Mladek <pmladek@suse.com>
>Reviewed-by: Lance Yang <lance.yang@linux.dev>
Ok, Reviewed-by: Bradley Morgan <brads@mainlining.org>
>Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
>---
> kernel/hung_task.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/hung_task.c b/kernel/hung_task.c
>index a5043188456d..49d47ae475ab 100644
>--- a/kernel/hung_task.c
>+++ b/kernel/hung_task.c
>@@ -277,7 +277,7 @@ static void hung_task_info(struct task_struct *t, unsigned long timeout,
> debug_show_blocker(t, timeout);
>
> if (!hung_task_warnings_budget)
>- pr_info("Future hung task reports are suppressed, see sysctl kernel.hung_task_warnings\n");
>+ pr_info("hung_task: further per-task details suppressed until warning budget is reset or panic is triggered (see sysctl kernel.hung_task_warnings)\n");
Cool.
> }
>
> touch_nmi_watchdog();
>@@ -363,6 +363,10 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
> return;
> }
>
>+ if (!hung_task_warnings_budget && !hung_task_call_panic)
>+ pr_info("hung_task: %lu hung tasks detected, warning budget exhausted\n",
>+ this_round_count);
>+
Nice!
> if (need_warning || hung_task_call_panic) {
> si_mask |= SYS_INFO_LOCKS;
>
>
--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/
prev parent reply other threads:[~2026-08-29 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 14:53 [PATCH v10 0/2] hung_task: Improve warning budget handling and task reporting Aaron Tomlin
2026-08-29 14:53 ` [PATCH v10 1/2] hung_task: Reset warning budget when problem gets resolved Aaron Tomlin
2026-08-29 14:53 ` [PATCH v10 2/2] hung_task: Log summary line when warning budget is exhausted Aaron Tomlin
2026-08-29 15:22 ` Bradley Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DC3C37-B2D8-4B74-BA05-87FCDFC20CBD@mainlining.org \
--to=brads@mainlining.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=chjohnst@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mproche@gmail.com \
--cc=neelx@suse.com \
--cc=nick.lange@gmail.com \
--cc=pmladek@suse.com \
--cc=sean@ashe.io \
--cc=steve@abita.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®