From: Oleg Nesterov <oleg@tv-sign.ru>
To: Linus Torvalds <torvalds@osdl.org>
Cc: William Lee Irwin III <wli@holomorphy.com>, linux-kernel@vger.kernel.org
Subject: Re: Make pipe data structure be a circular list of pages, rather than
Date: Fri, 07 Jan 2005 17:30:40 +0300 [thread overview]
Message-ID: <41DE9D10.B33ED5E4@tv-sign.ru> (raw)
Hello.
pipe_writev:
> + if (bufs < PIPE_BUFFERS) {
> + ssize_t chars;
> + int newbuf = (info->curbuf + bufs) & (PIPE_BUFFERS-1);
If i understand this patch correctly, then this code
for (;;)
write(pipe_fd, &byte, 1);
will block after writing PIPE_BUFFERS == 16 characters, no?
And pipe_inode_info will use 64K to hold 16 bytes!
Is it ok?
May be it make sense to add data to the last allocated page
until buf->len > PAGE_SIZE ?
Oleg.
next reply other threads:[~2005-01-07 13:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 14:30 Oleg Nesterov [this message]
2005-01-07 15:45 ` Alan Cox
2005-01-07 17:23 ` Linus Torvalds
2005-01-08 18:25 ` Hugh Dickins
2005-01-08 18:54 ` Linus Torvalds
2005-01-07 16:17 ` Linus Torvalds
2005-01-07 16:06 ` Alan Cox
2005-01-07 17:33 ` Linus Torvalds
2005-01-07 17:48 ` Linus Torvalds
2005-01-07 20:59 ` Mike Waychison
2005-01-07 23:46 ` Chris Friesen
2005-01-08 21:38 ` Lee Revell
2005-01-08 21:51 ` Linus Torvalds
2005-01-08 22:02 ` Lee Revell
2005-01-08 22:29 ` Davide Libenzi
2005-01-09 4:07 ` Linus Torvalds
2005-01-09 23:19 ` Davide Libenzi
2005-01-14 10:15 ` Peter Chubb
2005-01-07 21:59 ` Linus Torvalds
2005-01-07 22:53 ` Diego Calleja
2005-01-07 23:15 ` Linus Torvalds
2005-01-10 23:23 ` Robert White
2005-01-07 17:45 ` Chris Friesen
2005-01-07 16:39 ` Davide Libenzi
2005-01-07 17:09 ` Linus Torvalds
2005-08-18 6:07 ` Coywolf Qi Hunt
-- strict thread matches above, loose matches on Subject: below --
2005-01-20 2:14 Robert White
2005-01-16 2:59 Make pipe data structure be a circular list of pages, rather Linus Torvalds
2005-01-19 21:12 ` Make pipe data structure be a circular list of pages, rather than linux
2005-01-20 2:06 ` Robert White
[not found] <Pine.LNX.4.44.0501091946020.3620-100000@localhost.localdomain>
[not found] ` <Pine.LNX.4.58.0501091713300.2373@ppc970.osdl.org>
[not found] ` <Pine.LNX.4.58.0501091830120.2373@ppc970.osdl.org>
2005-01-12 19:50 ` Davide Libenzi
2005-01-12 20:10 ` Linus Torvalds
[not found] <200501070313.j073DCaQ009641@hera.kernel.org>
2005-01-07 3:41 ` William Lee Irwin III
2005-01-07 6:35 ` Linus Torvalds
2005-01-07 6:37 ` Linus Torvalds
2005-01-19 16:29 ` Larry McVoy
2005-01-19 17:14 ` Linus Torvalds
2005-01-19 19:01 ` Larry McVoy
2005-01-20 0:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DE9D10.B33ED5E4@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®