From: Nick Terrell <terrelln@meta.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Terrell <terrelln@meta.com>,
Nick Terrell <nickrterrell@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yann Collet <cyan@meta.com>, Kernel Team <kernel-team@meta.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream
Date: Tue, 21 Nov 2023 20:35:18 +0000 [thread overview]
Message-ID: <41F084AA-F027-4288-9F26-E33337E1516A@meta.com> (raw)
In-Reply-To: <CAHk-=wjcft4VEVBwSeaczuonUAGyT4BKt5PimekDpL9ygHC5cg@mail.gmail.com>
> On Nov 21, 2023, at 3:12 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> !-------------------------------------------------------------------|
> This Message Is From an External Sender
>
> |-------------------------------------------------------------------!
>
> On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@meta.com> wrote:
>>
>> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
>> do { } while (0) macros, because it complained about constant false
>> branches.
>
> Wow. That is some truly incompetent compiler people.
>
> I mean, really. As in "Why would you ever use that kind of garbage"
> incompetence.
>
> Honestly, any coding rule that includes "don't use the do-while-zero
> construct" is actively broken shit.
>
> Please just fix your upstream rules. Because they are incredible garbage.
Yeah, that’s the plan. Visual Studios fixed that compiler bug in VS2015 [0],
so we should be safe to migrate to safer macros. I’m going through and
doing that now, and will backport that to the kernel on top of this series.
[0] https://stackoverflow.com/a/36658783
> Linus
next prev parent reply other threads:[~2023-11-21 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 1:03 [PATCH 0/2] zstd: import upstream v1.5.5 Nick Terrell
2023-11-21 1:03 ` [PATCH 1/2] " Nick Terrell
2023-11-21 1:03 ` [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream Nick Terrell
2023-11-21 17:23 ` Linus Torvalds
2023-11-21 19:59 ` Nick Terrell
2023-11-21 20:12 ` Linus Torvalds
2023-11-21 20:35 ` Nick Terrell [this message]
2023-11-21 20:54 ` Linus Torvalds
2023-11-22 1:09 ` Nick Terrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41F084AA-F027-4288-9F26-E33337E1516A@meta.com \
--to=terrelln@meta.com \
--cc=cyan@meta.com \
--cc=giovanni.cabiddu@intel.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickrterrell@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®