From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, ak@linux.intel.com,
kan.liang@linux.intel.com
Subject: Re: [PATCH v2 1/5] perf vendor events intel: Add core event list for Alderlake-N
Date: Thu, 24 Nov 2022 10:18:40 +0800 [thread overview]
Message-ID: <41a60078-52c1-92bc-f8c1-178ac8994681@linux.intel.com> (raw)
In-Reply-To: <CAP-5=fVKXRcswFAMkTTBHTnvnEErhr0HExJ-HFKLHgZO71cbTw@mail.gmail.com>
On 11/24/2022 7:33 AM, Ian Rogers wrote:
> On Wed, Nov 23, 2022 at 5:40 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
>>
>> Em Wed, Nov 23, 2022 at 10:37:05AM -0300, Arnaldo Carvalho de Melo escreveu:
>>> Em Mon, Nov 21, 2022 at 01:17:12PM -0800, Ian Rogers escreveu:
>>>> On Mon, Nov 21, 2022 at 12:19 AM <zhengjun.xing@linux.intel.com> wrote:
>>>>>
>>>>> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>>>>>
>>>>> Alderlake-N only has E-core, it has been moved to non-hybrid code path on
>>>>> the kernel side. Add core event list for Alderlake-N, it is based on the
>>>>> ADL gracemont v1.16 JSON file.
>>>>>
>>>>> https://github.com/intel/perfmon/tree/main/ADL/events/
>>>>>
>>>>> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>>>>> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
>>>>
>>>> Acked-by: Ian Rogers <irogers@google.com>
>>>
>>> Is this just for 1/5? Or can I stick it to the whole series?
>>
>> But, after applying 1/5 I get:
>>
>> CC /tmp/build/perf/util/data-convert-bt.o
>> CC /tmp/build/perf/util/data-convert-json.o
>> /tmp/build/perf/pmu-events/pmu-events.c:55354:39: error: ‘pme_alderlaken’ defined but not used [-Werror=unused-const-variable=]
>> 55354 | static const struct compact_pmu_event pme_alderlaken[] = {
>> | ^~~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>> make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/pmu-events/pmu-events.o] Error 1
>> make[2]: *** [Makefile.perf:711: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> CC /tmp/build/perf/util/lzma.o
>> CC /tmp/build/perf/util/zlib.o
>> CC /tmp/build/perf/util/jitdump.o
>> CC /tmp/build/perf/util/bpf-event.o
>> LD /tmp/build/perf/util/perf-in.o
>> LD /tmp/build/perf/perf-in.o
>> make[1]: *** [Makefile.perf:240: sub-make] Error 2
>> make: *** [Makefile:113: install-bin] Error 2
>> make: Leaving directory '/var/home/acme/git/perf/tools/perf'
>>
>> Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin':
>>
>> 26,049,918,108 cycles:u
>> 47,580,273,158 instructions:u # 1.83 insn per cycle
>>
>> 4.655423698 seconds time elapsed
>>
>> 6.211852000 seconds user
>> 5.060661000 seconds sys
>>
>>
>> ⬢[acme@toolbox perf]$
>>
>> Please fix it and send a v2.
>>
>> - Arnaldo
>
> Thanks Arnaldo, my acked-by was for the whole series (missing cover
> letter in v2). The mapfile.csv change was reordered in v2, I asked for
> this. I think that change needs squashing into this one to avoid the
> unused case.
>
> Thanks,
> Ian
The whole series should have no build issue, the issue caused by the
mapfile .csv changes reordered from 0000 to 0004 in v2, I will merge the
mapfile.csv changes and this into one patch, and the build issue should
be fixed.
--
Zhengjun Xing
prev parent reply other threads:[~2022-11-24 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 8:20 zhengjun.xing
2022-11-21 8:20 ` [PATCH v2 2/5] perf vendor events intel: Add uncore " zhengjun.xing
2022-11-21 8:20 ` [PATCH v2 3/5] perf vendor events intel: Add metrics " zhengjun.xing
2022-11-21 8:20 ` [PATCH v2 4/5] perf vendor events: Add the cpuid " zhengjun.xing
2022-11-21 8:20 ` [PATCH v2 5/5] perf vendor events intel: Update events and metrics for alderlake zhengjun.xing
2022-11-21 21:17 ` [PATCH v2 1/5] perf vendor events intel: Add core event list for Alderlake-N Ian Rogers
2022-11-22 7:48 ` Xing Zhengjun
2022-11-23 13:37 ` Arnaldo Carvalho de Melo
2022-11-23 13:39 ` Arnaldo Carvalho de Melo
2022-11-23 23:33 ` Ian Rogers
2022-11-24 2:18 ` Xing Zhengjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a60078-52c1-92bc-f8c1-178ac8994681@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®