From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BCB3A1B5 for ; Sun, 29 Mar 2026 05:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760988; cv=none; b=p5w7mE8UAqAP3mb+WnkdAtAbRWpuJ3IebFZ0HN0jertXReTO0hNoLDcOTPH04aMS6jtANtL+HkNL2OEA+WWD5un77eVdn5jkVmn6VMlamG7MkQBOFXBfTI/9t7LCE84zz8icscJLqV4Qpd2+5pnDPd3waAvr1zlXWDuiwiFmqDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760988; c=relaxed/simple; bh=XcQG0KbCJc+fgQxt6iRAWzty/YENJD2WYcxNHX1Vfjw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IqP/jzIKYy4NNfSICHX4mno4+SopFiOXbhDUWuuEnnhMrtbCde9tbXvNw/plHp0ct3NcsF8KT0QXqxUEGKgXHjuuiPAGwyWlSo4MsaDF5bj1w9z5K/fvPaKcfSNas5b/PiUKT3csbkxT1A6gFJdv97paIfPK7U23Nx/QybFrY+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jjw2F9zp; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jjw2F9zp" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35c16db1b53so1820008a91.1 for ; Sat, 28 Mar 2026 22:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774760986; x=1775365786; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ifVKr93jGVH2yIRiQnF/GXY0v1LX7aDY3yGFgOalIIk=; b=Jjw2F9zpwOrRykjwQcU27DyN2/c0LGoj54W82iH+YwQbqGclhGNdiihVkQM0+uUuTh 581CjJlTAb6qLEre9pgXKjXxfbC+83nUetL4KE+xhoSEfhdd9UOM4wRBWv8wQFo7ekpw 4xh69kqq6ZM5RHHN4sX3O4BrIyPJA1WE45b8YqwdB1Dc+vDn8WUHiRzzEbROLhvkCG33 wYys8IV1tDLTzg5P8qNfpwLpPBWaaBkaJiDRZeNAyOT9By6/aRccHjMvX8u3gAPoJUV0 i57gaIm/KzqBurqChHCtcGBRSsuaqix0Ka3nIpmtQovTrFSnJq66trA+jGIyAEcmTTcR QNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774760986; x=1775365786; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ifVKr93jGVH2yIRiQnF/GXY0v1LX7aDY3yGFgOalIIk=; b=HxOhIIau8CKQ+uiu+4TX1OxKzYmsAw0DD4xFcRKuxqaOC5/+md6JzahjSGdi5Q7R34 IedoEPXBqpbL1YosTzi4qbssxZ2GV0NHmpd/xIbcmfAUx753tv+Vf7e8DR58/c/wPlF0 cCib3BhTMdgdzmacqsLxTO1MmayQAwTgUk7Ztx5UqXGnsN41KW+UcSY5VAu9U4WuCrdK sQdm+Wdg4AHuia21XOcvckHawWXJmFW7vIP4h+ZsCnqarO2Dk6LoGnXIW1qABl77zFdE qS9IlR25AlRJCg+O8jzT84ddjnQPLPnGFkFpZ+6GyUGm5kWtobqLVyvUxUpgnXVioKga OdNg== X-Forwarded-Encrypted: i=1; AJvYcCV0inLIrSMsmjK2jB8kq/CmTGFAeHBGTqYNwypYaLUhsvG1sN9XBMkNmUw7TNLuCMqy4g0vJaplV5U99eM=@vger.kernel.org X-Gm-Message-State: AOJu0YyxLBghvlKDfX9zBfoAqDtxuz9iy4W/MD7KWvhI6k4KsQXqSFYM tT24fof24xpH4NTZmOhEpaLcUJ3nLvRTrgsUfzjtty9ndajWxpDZ6l03 X-Gm-Gg: ATEYQzz2pGbCd4m59xxOx77jVdjFvNyK/C2+XskrW0GrjFGp2wdlb6LCfC3eFINCsn5 RT03DydtUobSwH7YBAms+mePsN2oAQiv7iRCSZxnVVKJOuC8OEIzvM/+rUpolGej+F8NiZD+4aE yQfqjgY1Z1MKwmd/We1U0L4tD1lMTu4J0dscsyd6qVitU9r8DbFjo509RTjgdbcaks9MUMRaC+6 d8fripVlKxntBNakFgSqxxlCMcWpWdnpM7z98itdNFFNT1XlpfYNOJbnIe5BaRVwCh2aN80g+9P 6S+79Ao1anWJSPE/qcE4wxsDl5uj7mE8BtjoJAMOcEIbI2aP+FjWl77ZKjRSZYXTI1Tz+iaQwDl b5QkFL3D2+27Jokv97K7wcQpE6SwWaT+RG1XKF1DK4lvZGi7AO04NOH2JITJfUPUUVr9kxsd/th Hhof+NLdUSj51txHDO4bRSOCDYMTyH/XntPsDVLROHrRUzirCJK1FaLfjdoCQnqPI5gNao8m/uu 1i/8KATXsA= X-Received: by 2002:a17:902:db08:b0:2b0:9c2b:641d with SMTP id d9443c01a7336-2b0cdc1fd28mr81702895ad.2.1774760986153; Sat, 28 Mar 2026 22:09:46 -0700 (PDT) Received: from [192.168.0.5] (124-218-201-66.cm.dynamic.apol.com.tw. [124.218.201.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2427c176fsm39183165ad.77.2026.03.28.22.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 22:09:45 -0700 (PDT) Message-ID: <41ad999d-786f-4aa5-b6bd-9faff016f7ff@gmail.com> Date: Sun, 29 Mar 2026 13:09:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support To: Andrew Lunn , "Russell King (Oracle)" Cc: Eric Woudstra , hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no, frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com References: <20260326153518.8387-1-lucienzx159@gmail.com> <6f42d92b-a26d-49a4-bef7-2227c252eea7@gmail.com> Content-Language: en-US From: "Lucien.Jheng" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Andrew Lunn 於 2026/3/28 下午 10:15 寫道: > On Sat, Mar 28, 2026 at 10:25:06AM +0000, Russell King (Oracle) wrote: >> On Sat, Mar 28, 2026 at 11:21:59AM +0100, Eric Woudstra wrote: >>> static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, >>> u32 pbus_data) >>> { >>> int ret; >>> >>> mutex_lock(&mdio->bus->mdio_lock); >> I wonder why we have phy_lock_mdio_bus() but not mdio_bus_lock()... >> Should a helper be provided at mdio bus level to complement the PHY >> level helper if we're going to have MDIO drivers directly manipulating >> the lock? > DSA is pretty much the only class of mdio driver. And they mostly need > to use: > > mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); > > Not the plain mutex_lock(). > > Hence it has not been added up until now. > > But yes, such a helper would make sense for a PHY driver having to do > odd things. > > Andrew Thank you for your feedback I will implement the helper you suggested for this in the next iteration.