mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eduardo Mucelli Rezende Oliveira <edumucelli@gmail.com>
To: mhiramat@kernel.org
Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] tools/bootconfig: Read the documented ftrace.notraces key
Date: Sat, 31 Oct 2026 19:35:30 +0100	[thread overview]
Message-ID: <41adc1bbe842f6f9240aa877b85d6b0310259743.1793471731.git.edumucelli@gmail.com> (raw)
In-Reply-To: <cover.1793471731.git.edumucelli@gmail.com>

The boot-time tracing documentation and trace_boot_set_ftrace_filter()
use ftrace.notraces for function exclusions. bconf2ftrace.sh instead looks
up ftrace.notrace, so the documented option produces no writes to
set_ftrace_notrace. This affects both the root instance and named ones.

Read the documented key so that the script applies the same exclusions
as the in-kernel bootconfig consumer.

Fixes: 7e66ef0046cc ("tools/bootconfig: Add a script to generate ftrace shell-command from bootconfig")
Link: https://docs.kernel.org/trace/boottime-trace.html#ftrace-per-instance-options
Signed-off-by: Eduardo Mucelli Rezende Oliveira <edumucelli@gmail.com>
---
I tested the documented ftrace.notraces setting with one and two function
names in a temporary tracefs instance on my Ubuntu machine, running
kernel 7.0.0-38-generic, with recording disabled. The original script
installed neither exclusion; the fixed script installed both exactly.
Fixture checks also cover the root instance, named instances, arrays,
an absent setting and the unchanged positive-filter path.

 tools/bootconfig/scripts/bconf2ftrace.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bootconfig/scripts/bconf2ftrace.sh b/tools/bootconfig/scripts/bconf2ftrace.sh
index 7745c97e7abd..e5a833171b57 100755
--- a/tools/bootconfig/scripts/bconf2ftrace.sh
+++ b/tools/bootconfig/scripts/bconf2ftrace.sh
@@ -258,7 +258,7 @@ setup_instance() { # [instance]
 	set_value_of ${instance}.tracer ${instancedir}/current_tracer
 	set_array_of ${instance}.ftrace.filters \
 		${instancedir}/set_ftrace_filter
-	set_array_of ${instance}.ftrace.notrace \
+	set_array_of ${instance}.ftrace.notraces \
 		${instancedir}/set_ftrace_notrace
 
 	if xbc_has_key ${instance}.alloc_snapshot; then
-- 
2.53.0


  reply	other threads:[~2026-10-31 18:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31 18:35 [PATCH 0/5] tools/bootconfig: Fix tracing script filters and histogram dependencies Eduardo Mucelli Rezende Oliveira
2026-10-31 18:35 ` Eduardo Mucelli Rezende Oliveira [this message]
2026-10-31 18:35 ` [PATCH 2/5] tools/bootconfig: Preserve quotes in exported event actions Eduardo Mucelli Rezende Oliveira
2026-10-31 18:35 ` [PATCH 3/5] tools/bootconfig: Ignore filter strings when resolving histogram variables Eduardo Mucelli Rezende Oliveira
2026-10-31 18:35 ` [PATCH 4/5] tools/bootconfig: Resolve histogram dependencies until no progress is made Eduardo Mucelli Rezende Oliveira
2026-10-31 18:35 ` [PATCH 5/5] tools/bootconfig: Match literal keys in tracing script helpers Eduardo Mucelli Rezende Oliveira
2026-11-13  2:27 ` [PATCH 0/5] tools/bootconfig: Fix tracing script filters and histogram dependencies Masami Hiramatsu (Google)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41adc1bbe842f6f9240aa877b85d6b0310259743.1793471731.git.edumucelli@gmail.com \
    --to=edumucelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®