From: "Chris Leech" <christopher.leech@intel.com>
To: "David Miller" <davem@davemloft.net>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently
Date: Fri, 2 Mar 2007 22:00:00 -0800 [thread overview]
Message-ID: <41b516cb0703022200t50f8ad62wfa04030f11649ff2@mail.gmail.com> (raw)
In-Reply-To: <20070302.202706.95898424.davem@davemloft.net>
> > This sounds like something that will always be wrong -- or in other
> > words, always be right for only the latest CPUs. Can this be made
> > dynamic, based on some timing factor?
>
> In fact I think this has been tweaked twice in the vanilla tree
> already.
This is actually just the same tweak you remember me posting before
and I never pushed to get it in mainline, but Jeff's right. The
problem isn't so much in the driver itself, as in how it's used by
I/OAT in the TCP receive code, there are inherent assumptions about
how long a context switch takes compared to how long an offloaded
memcpy takes.
I'm working on using completion interrupts for the device so as not to
end up polling when the CPUs are faster than the code was tuned for,
and doing it in a way that doesn't introduce extra context switches.
I'm hoping to have something ready for 2.6.22, or at least ready for
MM in that time frame.
As for this change in the short term, we did go back and make sure
that it didn't performance worse with the older CPUs supported on
these platforms. We should have tested more intermediate values
instead of just jumping from 1 t o 20 for that threshold.
- Chris
next prev parent reply other threads:[~2007-03-03 6:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 2:22 [PATCH 0/9] I/OAT fixes Chris Leech
2007-03-03 2:24 ` [PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently Chris Leech
2007-03-03 3:14 ` Jeff Garzik
2007-03-03 4:27 ` David Miller
2007-03-03 6:00 ` Chris Leech [this message]
2007-03-03 2:24 ` [PATCH 2/9] drivers/dma: handle sysfs errors Chris Leech
2007-03-03 2:24 ` [PATCH 3/9] ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma Chris Leech
2007-03-03 2:24 ` [PATCH 4/9] ioatdma: Remove the use of writeq from the ioatdma driver Chris Leech
2007-03-03 2:24 ` [PATCH 5/9] I/OAT: Add documentation for the tcp_dma_copybreak sysctl Chris Leech
2007-03-03 2:24 ` [PATCH 6/9] I/OAT: Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma Chris Leech
2007-03-03 2:24 ` [PATCH 7/9] I/OAT: Only offload copies for TCP when there will be a context switch Chris Leech
2007-03-03 2:24 ` [PATCH 8/9] I/OAT: warning fix Chris Leech
2007-03-03 2:24 ` [PATCH 9/9] I/OAT: fix I/OAT for kexec Chris Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b516cb0703022200t50f8ad62wfa04030f11649ff2@mail.gmail.com \
--to=christopher.leech@intel.com \
--cc=chris.leech@gmail.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome