mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chris Leech" <christopher.leech@intel.com>
To: "Boaz Harrosh" <bharrosh@panasas.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	jfs-discussion@lists.sourceforge.net,
	"Harvey Harrison" <harvey.harrison@gmail.com>
Subject: Re: [PATCH 1/4] 24-bit types: typedef and functions for accessing 3-byte arrays as integers
Date: Thu, 11 Sep 2008 07:12:57 -0700	[thread overview]
Message-ID: <41b516cb0809110712t45baa383y10650d8c6e4961c4@mail.gmail.com> (raw)
In-Reply-To: <48C8D0E0.5060908@panasas.com>

On Thu, Sep 11, 2008 at 1:03 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>> diff --git a/fs/jfs/endian24.h b/fs/jfs/endian24.h
>> index fa92f7f..45b6397 100644
>> --- a/fs/jfs/endian24.h
>> +++ b/fs/jfs/endian24.h
>> @@ -33,6 +33,9 @@
>>               ((__x & (__u32)0x00ff0000UL) >> 16) )); \
>>  })
>>
>> +#undef __cpu_to_le24
>> +#undef __le24_to_cpu
>> +
>
> Does #undef also work on inline functions? I didn't know that

No, it doesn't and those two lines don't do anything.  The two below
do, so this file gets touched anyway, and the JFS patch deletes the
entire file.  I'll fix this is there's some other reason to redo the
patchset again.

>>  #if (defined(__KERNEL__) && defined(__LITTLE_ENDIAN)) || (defined(__BYTE_ORDER) && (__BYTE_ORDER == __LITTLE_ENDIAN))
>>       #define __cpu_to_le24(x) ((__u32)(x))
>>       #define __le24_to_cpu(x) ((__u32)(x))
>> @@ -42,6 +45,8 @@
>>  #endif
>>
>>  #ifdef __KERNEL__
>> +     #undef cpu_to_le24
>> +     #undef le24_to_cpu
>>       #define cpu_to_le24 __cpu_to_le24
>>       #define le24_to_cpu __le24_to_cpu
>>  #endif

  reply	other threads:[~2008-09-11 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11  2:14 Chris Leech
2008-09-11  2:14 ` [PATCH 2/4] 24-bit types: convert iSCSI to use the __be24 type and macros Chris Leech
2008-09-11  2:15 ` [PATCH 3/4] 24-bit types: Convert jfs to use the common 24-bit types Chris Leech
2008-09-11  2:15 ` [PATCH 4/4] 24-bit types: Convert Open-FCoE to use __be24 type and macros Chris Leech
2008-09-11  8:03 ` [PATCH 1/4] 24-bit types: typedef and functions for accessing 3-byte arrays as integers Boaz Harrosh
2008-09-11 14:12   ` Chris Leech [this message]
2008-09-14 10:32     ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41b516cb0809110712t45baa383y10650d8c6e4961c4@mail.gmail.com \
    --to=christopher.leech@intel.com \
    --cc=bharrosh@panasas.com \
    --cc=chris.leech@gmail.com \
    --cc=harvey.harrison@gmail.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®