From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61622C43464 for ; Fri, 18 Sep 2020 01:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3067C208DB for ; Fri, 18 Sep 2020 01:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbgIRBXC (ORCPT ); Thu, 17 Sep 2020 21:23:02 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59246 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725886AbgIRBXB (ORCPT ); Thu, 17 Sep 2020 21:23:01 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 54ECF222852D89EE1CDF; Fri, 18 Sep 2020 09:22:59 +0800 (CST) Received: from [10.174.179.108] (10.174.179.108) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 18 Sep 2020 09:22:55 +0800 Subject: Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr() To: Cong Wang References: <20200916141728.34796-1-yuehaibing@huawei.com> CC: David Miller , Jakub Kicinski , "Jiri Pirko" , Linux Kernel Network Developers , LKML From: Yuehaibing Message-ID: <41b8d535-5c66-51ec-8865-d97d53868227@huawei.com> Date: Fri, 18 Sep 2020 09:22:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/18 2:34, Cong Wang wrote: > On Wed, Sep 16, 2020 at 9:33 AM YueHaibing wrote: >> >> It is never used, so can remove it. > > This is a bit confusing, it was actually used before, see commit > ab0d76f6823cc3a4e2. Yes,thanks for reminding, will be careful later. > . >