From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D61C8C7EE29
	for <linux-kernel@archiver.kernel.org>; Mon, 29 May 2023 15:46:01 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229992AbjE2PqB (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 29 May 2023 11:46:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40428 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230036AbjE2Pp5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 May 2023 11:45:57 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 693ABC4;
        Mon, 29 May 2023 08:45:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=rOnUNLgy0uJnQ1Nieea+DB3PN7mIsSIgBYdXTpxYz0s=; b=eDwOtnbbikiiTvgrnireaeLzjV
        UK3lwNgEGiKJQQn2kFkNubbwxCXwKOLhM6rFtQdIp3oPcDMJPiOSyjOzv7XiG0NIRdqq5jl0LN5mX
        S6bXsbvi8RevSEG6O3lxir4+9YhOxcOwNopAn/jsutd0N5IyKB6NHaUSw9clcY9Ke8/M=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1q3f45-00EF3c-4j; Mon, 29 May 2023 17:45:45 +0200
Date:   Mon, 29 May 2023 17:45:45 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-leds@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [net-next PATCH v3 08/13] leds: trigger: netdev: add support for
 LED hw control
Message-ID: <41bbeede-b88a-431f-8bcf-ba3c8a951dc5@lunn.ch>
References: <20230527112854.2366-1-ansuelsmth@gmail.com>
 <20230527112854.2366-9-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230527112854.2366-9-ansuelsmth@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  static bool can_hw_control(struct led_netdev_data *trigger_data)
>  {
> +	unsigned int interval = atomic_read(&trigger_data->interval);
>  	struct led_classdev *led_cdev = trigger_data->led_cdev;
> +	unsigned long default_interval = msecs_to_jiffies(50);

nitpick:

We have 50 in netdev_trig_activate(). Now it is used twice, it would
be nice to replace it with a #define. I doubt it will ever get
changed, but we do want them to be identical.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew