From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B173BED63 for ; Mon, 11 May 2026 08:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778489583; cv=none; b=TxjwDgFKsTKRB432g6H2SPRLjY4BBAlXrCNniPgcN0thxVLK5Z7g9mhmkvF3xZIH4fHPduEyyjp8V6LrMyg2TTVZcKYZCs5hiA8vQUTxm+OImGXQ0vyT7l53SPj2KuhTeLriy7ynlsn2jIMEqRLMtA0xmhg3Y5Fco02FL9mpn9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778489583; c=relaxed/simple; bh=1Vb7u84GjOzr+CW7azCqmocyWDL053FJeunJoBfC3h8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AK/JbMwTSX/rgJ744ojeoU6LaiU3vjTMOakJRnCu9YR7dynoVEad2SUJnuUNkF4Smhp5ThadGUEqGcXvfs3vvEQZpTfEjPJTNI4XRg0zh7/UnyBmRW+OftjEncLsj5t2YHdeUIoMXV8VnC9sLf/gS5Tn9qNO+4x1hiqtX2s7ywI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XBKjNaVm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M81xbXab; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XBKjNaVm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M81xbXab" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778489581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9tuOG0LtkLDTSKD1+Re+ayATul75v5uc/Qit0qQeEcQ=; b=XBKjNaVmGN7X2cK5BT/mF0LfjRUX+P9nwKf1T2NMY9vGD9qrJtfYiCqBQx50fVY8M6RMJz 60QvVkMxR+9DG+PdIA1H1arpKTrxUh13suSCAAsXpBMYO0MoAkGFBPNrNzWpFtyEG5CsXd nsfKAfQV2I5PSlDgzU+dvj4OkI4vXw0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-h8r6QQl1MCCx6n1o26xc_A-1; Mon, 11 May 2026 04:52:59 -0400 X-MC-Unique: h8r6QQl1MCCx6n1o26xc_A-1 X-Mimecast-MFC-AGG-ID: h8r6QQl1MCCx6n1o26xc_A_1778489579 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44d9ace59efso2732167f8f.1 for ; Mon, 11 May 2026 01:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778489578; x=1779094378; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9tuOG0LtkLDTSKD1+Re+ayATul75v5uc/Qit0qQeEcQ=; b=M81xbXabH677+pbHKUrn97iwtczDI+39Dz14xlTChtNI8cqvNk4i1Boi1TjZxyQw6M ZGmE5vuiL5UNu285mP2phTlrboPAX2T6UKpXI45FAFMsdRGFtWtodBf3MrSvhD1EJmVI 19xENnmKdRN/PkxY6kytSMOy5T6uW5xBiji425O/glejSWlcdNIFSVMmVmDo2gZb66NX fHb8c8Ldpp9YuQ7e7t818F7WxSVPQrXfJ6tey9vFsRoGy55aUfJJNhUuQnnQ/vRL3L+t 5RSxxbMw0idiegi6bZvoRxzsZuakuuLQsrVQ3KmaLELwLuX+zyIe4GlKOrwyPB9Ok3xO C6Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778489578; x=1779094378; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9tuOG0LtkLDTSKD1+Re+ayATul75v5uc/Qit0qQeEcQ=; b=GGkcY6UB2SUzBgm44XQ1rOHI67wsbJeo8LdmA/n+WIz54t4EOHXm0S4BDilcD7yCKF ij/HeDCrm9KhXFzlb0KOJ9Pcr6yIjI7DF4EPPdUFS5o0Xcf8ZmD3Rub8bpl15Bp1tZPl 61FKvyAJLXr2UumM7IM17myPdVLDdw0iIaPzYs7VOc27jz/d8n3wjenvqAwZNJxknQMp GJ9ZGr7qg0RpCH0HHCldh7JaUl6bSgYOvuHBlopqOvYn1GmXYTmZeI/ofJYf8MbazYYn X9vBPRF2Oq/9IGkNsDX4723sXJSao83DQNXeQ5MhNixQD6/p9AmShsmqt2doTFuKOCOm J/kg== X-Gm-Message-State: AOJu0YzK7/KthCYuD479GTWZAUqcqkbv1UY6XxHyG1DEFd0+2fe+L/Ry Z5rdpo+pypFzkzvO5fNSP3Jq5UfqPDDPYQKk5JcTB4zaVwgC1dwPEarcvswzZpalssQeugt7Gt+ wCqiv+mczlAFEX9kIztHs3x1GEBQbAdl1vsbRouaVZ3Y1Oy3lNmJxuOvNKD69I2RMpGTpmMC0yx GbvaycK+rmPU4JI6ayp02gyRwAFDY7BqUoUyoVQ0EiwrS1Fw== X-Gm-Gg: Acq92OH0SWgTL2nYNY8d28epaSEH8q+SW6tNrM4Z1I+z7Wo+hl5JRtdcgcg5uuGnEY8 6tTur/ZFqEQEeuxZAxnJOULnRDu9hPj2J6KKdjnoJJZWi3pvgddT2M5G7UVSn5LUpMw1kTnMw0E PTCv22jLTG28PB20DyKXhch+bPKEoBNIWhcvarLEojc7TqbESjZzIsfxunrtzc10IL/N1efQZKQ dTw7URy4MaTmeObUO8zTYvsdTeeyK20njvn1z1wbAemvYRW9Vjl3nsiTWCw5Me3nxDEEeQp+Ywp +7NSKzKTvvRJnC8gdL5Mqv+15aYrkD2HlKn+7qcH1cx35MiCK1KhQ3btn8G3QfIO7uT8pnxOJfT dXtDQpt10g32/errkDOoBitS/8gvW1sMc43DAZsXi/tP29sPHuqo= X-Received: by 2002:a05:600c:6299:b0:489:1f97:6b1d with SMTP id 5b1f17b1804b1-48e706edd0dmr143157555e9.28.1778489578243; Mon, 11 May 2026 01:52:58 -0700 (PDT) X-Received: by 2002:a05:600c:6299:b0:489:1f97:6b1d with SMTP id 5b1f17b1804b1-48e706edd0dmr143156535e9.28.1778489577648; Mon, 11 May 2026 01:52:57 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e80ca2666sm90929945e9.10.2026.05.11.01.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 01:52:57 -0700 (PDT) Date: Mon, 11 May 2026 04:52:52 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v6 02/30] mm: mempolicy: fix interleave index for unaligned VMA start Message-ID: <41bd50fdaae943e1a79215ea4000322e74a823be.1778488966.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent The NUMA interleave index formula (addr - vm_start) >> shift gives wrong results when vm_start is not aligned to the folio size: the subtraction before the shift allows low bits to affect the result via borrows. Use (addr >> shift) - (vm_start >> shift) instead, which independently aligns both values before computing the difference. No functional change for current callers: the fix only affects NUMA interleave and weighted-interleave policies. Current large-order callers either pre-align the address (vma_alloc_anon_folio_pmd) or do not use NUMA interleave (drm_pagemap). All other callers use order 0 where the old and new formulas are equivalent. However subsequent patches in this series add large-order callers that pass unaligned fault addresses, making this fix necessary. Signed-off-by: Michael S. Tsirkin --- mm/mempolicy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 6832cc68120f..39e556e3d263 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2049,7 +2049,8 @@ struct mempolicy *get_vma_policy(struct vm_area_struct *vma, if (pol->mode == MPOL_INTERLEAVE || pol->mode == MPOL_WEIGHTED_INTERLEAVE) { *ilx += vma->vm_pgoff >> order; - *ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + order); + *ilx += (addr >> (PAGE_SHIFT + order)) - + (vma->vm_start >> (PAGE_SHIFT + order)); } return pol; } -- MST