From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A1CCC433EF for ; Thu, 7 Jul 2022 10:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235099AbiGGKrG (ORCPT ); Thu, 7 Jul 2022 06:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234884AbiGGKrF (ORCPT ); Thu, 7 Jul 2022 06:47:05 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 03C244D4C0; Thu, 7 Jul 2022 03:47:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 238E31063; Thu, 7 Jul 2022 03:47:04 -0700 (PDT) Received: from [10.57.11.194] (unknown [10.57.11.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E2DA3F792; Thu, 7 Jul 2022 03:47:00 -0700 (PDT) Message-ID: <41c333e1-2545-f6be-2db2-9061297d0b9a@arm.com> Date: Thu, 7 Jul 2022 11:46:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 0/4] Energy Model power in micro-Watts and SCMI v3.1 alignment Content-Language: en-US To: rafael@kernel.org Cc: daniel.lezcano@linaro.org, amitk@kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, viresh.kumar@linaro.org, dietmar.eggemann@arm.com, nm@ti.com, sboyd@kernel.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220707071555.10085-1-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: <20220707071555.10085-1-lukasz.luba@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 7/7/22 08:15, Lukasz Luba wrote: > Hi all, > > This is a patch set which changes Energy Model power values scale to > micro-Watts. It also upgrades the SCMI performance layer + scmi-cpufreq > driver to leverage the SCMI v3.1 spec and process micro-Watts power values > coming from FW. The higher precision in EM power field solves an issue > of a rounding error, which then can be misinterpreted as 'inefficient OPP'. > An example rounding issue calculation is present in patch 1/4 description. > > Changes: > v2 > - simplified 32bit checks for max number of CPUs preventing energy > estimation overflow > - added Reviewed-by and ACKs > v1 [1] > > Regards, > Lukasz Luba > > [1] https://lore.kernel.org/lkml/20220622145802.13032-1-lukasz.luba@arm.com/ > > Lukasz Luba (4): > PM: EM: convert power field to micro-Watts precision and align drivers > Documentation: EM: Switch to micro-Watts scale > firmware: arm_scmi: Get detailed power scale from perf > cpufreq: scmi: Support the power scale in micro-Watts in SCMI v3.1 > > Documentation/power/energy-model.rst | 14 +++---- > drivers/cpufreq/mediatek-cpufreq-hw.c | 7 ++-- > drivers/cpufreq/scmi-cpufreq.c | 15 +++++++- > drivers/firmware/arm_scmi/perf.c | 18 +++++---- > drivers/opp/of.c | 15 ++++---- > drivers/powercap/dtpm_cpu.c | 5 +-- > drivers/thermal/cpufreq_cooling.c | 13 ++++++- > drivers/thermal/devfreq_cooling.c | 19 ++++++++-- > include/linux/energy_model.h | 54 +++++++++++++++++++-------- > include/linux/scmi_protocol.h | 8 +++- > kernel/power/energy_model.c | 24 ++++++++---- > 11 files changed, 132 insertions(+), 60 deletions(-) > I got ACKs (and on Reviewed-by) for this patch set. Could you take this via your PM tree, please?