From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 769683396E0 for ; Tue, 16 Dec 2025 21:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765921250; cv=none; b=Htj6/LdaPcMc7f61XLJYpwqZrgSJWQiJw2QHnqZRDeQRqXyw2f2l7YXZy07fZy+9wSMZeaE1ScpFyShe5fFg+arP56HAsBwapAmvNVDWmRbQyeDUZIkjzB3yoMaIn2V6zRgnatrA7WX2dpCytDqUxtUBqLintT2+eQb43vMo0e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765921250; c=relaxed/simple; bh=dEXqCfld4X36KSV7nqClq7+cDI89ydHsFPBmfdJHtxg=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=t+GOEBZGYjGvbNW7GIzs/7qXnyaIItoqBF+hIWAaCKTd7xjtp83YaiNeKk1CjghUfMCoVdjkOx4QoWw3RF6cpEniQlrag4SzHE1+AMK5OWxXKnNmqoNfntA+l1hs1LJVeWAN5qqcwbMYwnyl/Sd29o3vQps6yBwotj1XnJR63hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=EH5fsjh2; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="EH5fsjh2" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-88a3d2f3299so29715676d6.2 for ; Tue, 16 Dec 2025 13:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1765921246; x=1766526046; darn=vger.kernel.org; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=O4AELFpU1THdwARc02Y1V5uIhLUDaIBDQWmAVMQD+KI=; b=EH5fsjh2cp/Od/BNhWRZsM0qptmnG94aGWh28rEC7obQ7WkGRtfv7wCgKsI5mTAclo EhQERNo50Xek4zF+jRE95P9V3ovSUsju2t0h3IJvo9r04TLerBPoI/n7aZ03WGNfbu+g AGd/ulFGI4k5VLRJuIjB9O9qegtJek3I72YTsmIeV/vCRm4FlCn+OP8aL2KUp0k2gUYH kH6ajJZa/udDZnM5U4PIesdfkzmEg+0hL02P/rt6tclFdPQiAom9uiE5qLp1E6skPAKz dcbWl0cpeOYFMIEh+6ygI43vWBTKxOiEjLvofe7qBgm8ajXFUdtl7t5+ZquxBfBfjBky 5Mkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765921246; x=1766526046; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:to :from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O4AELFpU1THdwARc02Y1V5uIhLUDaIBDQWmAVMQD+KI=; b=FByOQbIm7afa23ca1Ouue1filNa2ov9Nyz2hvkEkPy9tSpnNNhlV5lnD4XIZmYdJaz 9LKvn6SChwjLnddt7XE5ECeDFMK7YHEH/b3Wr+fzeKb0b1NS2fKQi6Y0gSJi9lCv4X1m 8+O7LLgixhBAJdV+68DKQL3XnGJ8B71aze5hdFFV53d/+ibC90UNov6AQk1+20d/fPBx 95hZ0q640bcoUC3TJBPdKbYIuHKtx6eya6cR5SShFmUgrTtXIlEmHZqzlPfhm3V7inOa 3U4VmnQKb8q+FN17JKaZG8nBNA0HiFoApVepPQ9FaJV5WAsP50UWX2mrzy3vQYH4dNl1 wusQ== X-Forwarded-Encrypted: i=1; AJvYcCVtOVEkYOvJDWr9dmV8HZFpz/Dcg0CwMUU7OTn2V2lNqr0WNIk03kkMNwU01jKrq3m3yW5vMKar1/xJwdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyaJXSEbR8rlOho8ErIt3EgD00xRoPB2gCx9+aDzM2fnGK+3Rq9 sYaFyLvnsCkIwm2ovJ9gkVyfVkx67rtmo69QE3VF2yxgVaYyfZNNBbX26k+FYCM+K4UMfVWF5dV tNGemxzU= X-Gm-Gg: AY/fxX6Xf9YDc6VuaN1OgMy0iAXpGsMg598w23HlvOXKlkVUOdM1hmzoJzb1P2+tfgX HhrWMKRivaaNBgIjhf8Ew3oSSlZ8Hh38EckdbR63S0/msboreNfrjokB6e/1WDZzI8CWIh7Odhf QBubkm2WwCntLAbqG5fWygglzD3M8ZV1JeU43pauFpi/9kDny6pttUAhPhqNqUChlmnRHiwVB5h 0amk8FOPr3bwrH4fZ0Y1/kp+XqSzmk5Dl5tS5L7IKegPrq6eBsIrYTij6FMHDB5uB/REk2TUO5k pUgUS3CPg3mzilfpXk/5iRN7MetJ055J+GsN2bbSmeb6u+r6w5W1eMKyKCY1QvwEAwsTAbiWwS0 HJC1pKl1LfMO8Fa8K1MQfxUVhgYt5lVEOeWRHPGVrbF+e68OwhMfvnIvtNHdRRK7odBelLXKIxQ EoORemdTS4koTqWgqJ X-Google-Smtp-Source: AGHT+IEh3+aMTT+69SVk2qQBnQj0741wIei3uKMlKrQWP8MB9v7jQGSEyVTJ0cWhWW2Caga3ImCEOg== X-Received: by 2002:a0c:ed42:0:b0:888:8096:a09c with SMTP id 6a1803df08f44-8888096a4f6mr180400916d6.62.1765921246135; Tue, 16 Dec 2025 13:40:46 -0800 (PST) Received: from ?IPv6:2606:6d00:17:7b4b::c41? ([2606:6d00:17:7b4b::c41]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88993b41845sm82007646d6.2.2025.12.16.13.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 13:40:45 -0800 (PST) Message-ID: <41e00b0f4c667ff8e8a8f8b81f64fe1bbca7c001.camel@ndufresne.ca> Subject: Re: [PATCH v11 07/12] media: mediatek: jpeg: fix decoding resolution change operation From: Nicolas Dufresne To: Kyrie Wu , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Tue, 16 Dec 2025 16:40:44 -0500 In-Reply-To: <20251202094800.6140-8-kyrie.wu@mediatek.com> References: <20251202094800.6140-1-kyrie.wu@mediatek.com> <20251202094800.6140-8-kyrie.wu@mediatek.com> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-WiTrr4gl+5/mCAw/rMLC" User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-WiTrr4gl+5/mCAw/rMLC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Le mardi 02 d=C3=A9cembre 2025 =C3=A0 17:47 +0800, Kyrie Wu a =C3=A9crit=C2= =A0: > 1.add a judgement for src buffer to avoid kernel crash > in the stop streaming function; > 2.When a resolution changing occurs, it needs to set new > resolution parameter immediately and then report this event. > Otherwise, if the original software process is maintained, > the resolution change event is reported firstly, the CPU is > dispatched to the app to process the event, and the driver > does not set a new resolution, which will cause parameter errors. > 3.After a resolution change occurred, decoding should not continue, > needs to wait until new buffers are ready and the state machine > changed. I mention this in other patchset, very often, 3 bullets means 3 distinct changes. Don't use bullets. Reflow this text, rework this text, there is ma= ny syntax error here. >=20 > Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interfac= e") >=20 > Signed-off-by: Kyrie Wu > --- > =C2=A0drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 9 +++++++-- > =C2=A01 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > index 5ffaee4dcd19..9233bbfe2d97 100644 > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > @@ -887,7 +887,8 @@ static void mtk_jpeg_dec_stop_streaming(struct vb2_qu= eue > *q) > =C2=A0 > =C2=A0 vb =3D v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); > =C2=A0 src_buf =3D mtk_jpeg_vb2_to_srcbuf(&vb->vb2_buf); > - mtk_jpeg_set_queue_data(ctx, &src_buf->dec_param); > + if (!IS_ERR_OR_NULL(src_buf)) > + mtk_jpeg_set_queue_data(ctx, &src_buf->dec_param); The lack of vb2_wait_for_all_buffers() might explains this better, you migh= t not need to do random null checks like this. Nicolas > =C2=A0 ctx->state =3D MTK_JPEG_RUNNING; > =C2=A0 } else if (V4L2_TYPE_IS_OUTPUT(q->type)) { > =C2=A0 ctx->state =3D MTK_JPEG_INIT; > @@ -1749,11 +1750,15 @@ static void mtk_jpegdec_worker(struct work_struct > *work) > =C2=A0 > =C2=A0 if (mtk_jpeg_check_resolution_change(ctx, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 &jpeg_src_buf->dec_param)) { > - mtk_jpeg_queue_src_chg_event(ctx); > + mtk_jpeg_set_queue_data(ctx, &jpeg_src_buf->dec_param); > =C2=A0 ctx->state =3D MTK_JPEG_SOURCE_CHANGE; > + mtk_jpeg_queue_src_chg_event(ctx); > =C2=A0 goto getbuf_fail; > =C2=A0 } > =C2=A0 > + if (ctx->state =3D=3D MTK_JPEG_SOURCE_CHANGE) > + goto getbuf_fail; > + > =C2=A0 mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf); > =C2=A0 ret =3D pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev); > =C2=A0 if (ret < 0) { --=-WiTrr4gl+5/mCAw/rMLC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaUHR3AAKCRDZQZRRKWBy 9CwsAQCyuxoAqjtYHse6WiWw9r1vAIqN8RsAZzvbh5RFyVgTgQD/XjRgo9FDnGk4 3bziswMEpYDICcpXmalCD6/v7owEUQs= =aXJ6 -----END PGP SIGNATURE----- --=-WiTrr4gl+5/mCAw/rMLC--