From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A1433A9FE for ; Wed, 20 May 2026 22:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315651; cv=none; b=MmRYb50+u/TvspmXmqHKSNGf36/LK8jatksV//OpM9bFbTl9P27dMbIuyQSdtfp62O389/VykS/4/E2Lqi1kU0Un28PhOix24EHq+E4iPVpflpi1Ozu8bI9yjuyLQxJZsGEGG26mh5eY9PuRHXfBsSUYw8GZc0WUDP8C7656kqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779315651; c=relaxed/simple; bh=DRd7Xt1v5jz8DB3KNV92VDBlshly3yQmr6003O/RIg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k8dwhNrmo1sa1qey6gQXSWXQ1OPYJMfXM3erfKN/g1l1N7+MCI+SXM34f+CtLfw1agrFiXOq3McK+MixDDWzrnFbVlKDZluCrs2Dw9aW6RwbNk+P0TAcClU0PuYyZRVq8ziMB1WqLazuhc9rNNlWRF//k+pQ6EFONoqFn06D1tM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Un5rIHDj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OnojuL+e; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Un5rIHDj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OnojuL+e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779315649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KLmapuZeL0TvG+NgLwJQJBgDKEe1s3MFixcWgGLhrA=; b=Un5rIHDjKLgm93QVHQlFpzC194JVWPIrkMCOvoScTGRITGpea3jPFStT8H6zHZxZcGXaIV uRR4vlUw0AQ/pIFm191P9491fYyi4PoBM9b6ppX6jlLOdMtIgYAIDizYvkqlBV3oR9UpMy v5Bp0/ppqqC4KK3knBT6UEbU9fXgtHo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-Yyv7GTVyM_2tUpV-yps3IA-1; Wed, 20 May 2026 18:20:42 -0400 X-MC-Unique: Yyv7GTVyM_2tUpV-yps3IA-1 X-Mimecast-MFC-AGG-ID: Yyv7GTVyM_2tUpV-yps3IA_1779315641 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-67fd8c53ccdso691247a12.3 for ; Wed, 20 May 2026 15:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779315641; x=1779920441; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6KLmapuZeL0TvG+NgLwJQJBgDKEe1s3MFixcWgGLhrA=; b=OnojuL+eXht9TI6g/dRSIHjBSqqzU0S4tFKYCiq7N4vUK0dOvoy8nkkW0PmVe/0vtu Egk++0I2SPYLXLYnyJcy/TJUix4v0ogdHXHRzjnpNHB9bvY4BxyEfYc9sll9TmGflk+N 5k/3ly63qdQI4eah/4oCf9K544hwKmxHW1zeR5TvBuf7EZL4SdFqPuWO1unTgdutABnb +YUNpW58nzuyHE1nLaFnarbm4ufv3KdVbm2EtFZ8H/LeQGOQ/iEDeZ6HvlfrN1mtLO0J E7i8fXvPrIoALStI1JDqGxq0dH8mIihOkrcGSjqV5Lzzn6YsrmeGGrB2PqFx9r3s0NMa EDUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779315641; x=1779920441; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KLmapuZeL0TvG+NgLwJQJBgDKEe1s3MFixcWgGLhrA=; b=jimBtXwvLNL83wj2QQvymPjzNW6iNdrEgfAyadWMbbwMjinR4ZLe/+A2r8nrXHHtWN 5hxx57nxmREFi5lThWxkz3FtkqEvnhYsSDuUvwijkp2ooC2Yxrrzx/BaDbZlyMv5h+a/ tryKkv80/qgZ3K5p7CnrTNnpuHRSp8CYDy0y1cW9B7m8ce2EXpf0OeSgf6Rja7n2mwr6 9EBRndHf2F+lhoMcCq+c0kFgmr/2fSB7DYqxJWz6/E2B6xUP+ECOngAmRBQf7FiWSzp7 t63/kEfJQ1dv6zHAg81rgo0inHAGmGiuoCN+ILb6hXEai2HnUk1s5Ker9hODhLpro7ev 7tQA== X-Gm-Message-State: AOJu0Yz9oSLudrJ6vlM2VrLF/joSr9qX2leGiDMZRAYg9BCEg0wOLVVK J92KlDlETjB1+aP1YVgXdE8EpBfEQDOFXAVJvsKMXI7epcNQ1B5NEmCd28RaNwcxie+e9N9nsUR UvyhjP1vo21ZzyYoBCUv+kP6MzQ8Al1rAD1Tt7VNWW6wAY6PyCeDpuKWDw5GxSspuFvUb+ewFtg 1Ob3DBWE2Gt8DMmyQYE+6Afa9mAU3va7lYYuuk5xPKgH0= X-Gm-Gg: Acq92OHplYGyX6uclaJ0vjaYgFkuLJjbX+Fui2eoEV9sP3aCnGw6f6llXpVYrMxs3sH tTTRoqLR307RW8caW4d7vCn5VTQgCxqdHvpoeCZSGpnineDtfKdYB7vk+f/Xbw2g/rZZ8e8qxfP 15N0YYq+xqworUY5H0P4QGCh1jW5u8JAfPa7OoFpoh75MbdOsi0nYwrC9SzN+7c15ek/1WqjDlI NIXT+ubwmjJ9pKEVrGOMhDYVtzRj9YMpoY/GMKcAg7oBHS9NiCBowKL6S/YYMLlmC1CIQvo46wF s/6Jwpqwfllll+o4Hymlz72EgWM5uANCRhvMHi6PV9HcazD2cKE26lMVzV+xQpUl7J4uuAyg7Ij gePrsrwPDxXxJ5LHYjUhhE6gaNMvny/WRmJrb0MA6OT8= X-Received: by 2002:a05:6402:84c:b0:683:5589:4317 with SMTP id 4fb4d7f45d1cf-688361e61a7mr34143a12.11.1779315640617; Wed, 20 May 2026 15:20:40 -0700 (PDT) X-Received: by 2002:a05:6402:84c:b0:683:5589:4317 with SMTP id 4fb4d7f45d1cf-688361e61a7mr34086a12.11.1779315639756; Wed, 20 May 2026 15:20:39 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-684744d13aesm5851373a12.18.2026.05.20.15.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:20:38 -0700 (PDT) Date: Wed, 20 May 2026 18:20:31 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v8 04/37] mm: page_reporting: allow driver to set batch capacity Message-ID: <41e4b7824bbd0fbc94a1c9a52ac1f261fb032a8a.1779315441.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Add a capacity field to page_reporting_dev_info so drivers can control the maximum number of pages per report batch. This is useful when the driver needs to reserve virtqueue descriptors for metadata (e.g., a bitmap buffer) alongside the page buffers. The value is capped at PAGE_REPORTING_CAPACITY and rounded down to a power of 2. If unset (0), defaults to PAGE_REPORTING_CAPACITY. The virtio_balloon driver sets capacity to the reporting virtqueue size, letting page_reporting adapt to whatever the device provides. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- drivers/virtio/virtio_balloon.c | 5 +---- include/linux/page_reporting.h | 3 +++ mm/page_reporting.c | 28 +++++++++++++++++----------- 3 files changed, 21 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f6c2dff33f8a..6a1a610c2cb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1017,10 +1017,6 @@ static int virtballoon_probe(struct virtio_device *vdev) unsigned int capacity; capacity = virtqueue_get_vring_size(vb->reporting_vq); - if (capacity < PAGE_REPORTING_CAPACITY) { - err = -ENOSPC; - goto out_unregister_oom; - } vb->pr_dev_info.order = PAGE_REPORTING_ORDER_UNSPECIFIED; @@ -1041,6 +1037,7 @@ static int virtballoon_probe(struct virtio_device *vdev) vb->pr_dev_info.order = 5; #endif + vb->pr_dev_info.capacity = capacity; err = page_reporting_register(&vb->pr_dev_info); if (err) goto out_unregister_oom; diff --git a/include/linux/page_reporting.h b/include/linux/page_reporting.h index 9d4ca5c218a0..5ab5be02fa15 100644 --- a/include/linux/page_reporting.h +++ b/include/linux/page_reporting.h @@ -22,6 +22,9 @@ struct page_reporting_dev_info { /* Minimal order of page reporting */ unsigned int order; + + /* Max pages per report batch (default PAGE_REPORTING_CAPACITY) */ + unsigned int capacity; }; /* Tear-down and bring-up for page reporting devices */ diff --git a/mm/page_reporting.c b/mm/page_reporting.c index 7418f2e500bb..ae8d55f89f25 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -174,10 +174,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, * list processed. This should result in us reporting all pages on * an idle system in about 30 seconds. * - * The division here should be cheap since PAGE_REPORTING_CAPACITY - * should always be a power of 2. + * The division here should be cheap since capacity should + * always be a power of 2. */ - budget = DIV_ROUND_UP(area->nr_free, PAGE_REPORTING_CAPACITY * 16); + budget = DIV_ROUND_UP(area->nr_free, prdev->capacity * 16); /* loop through free list adding unreported pages to sg list */ list_for_each_entry_safe(page, next, list, lru) { @@ -222,10 +222,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_unlock_irq(&zone->lock); /* begin processing pages in local list */ - err = prdev->report(prdev, sgl, PAGE_REPORTING_CAPACITY); + err = prdev->report(prdev, sgl, prdev->capacity); /* reset offset since the full list was reported */ - *offset = PAGE_REPORTING_CAPACITY; + *offset = prdev->capacity; /* update budget to reflect call to report function */ budget--; @@ -234,7 +234,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_lock_irq(&zone->lock); /* flush reported pages from the sg list */ - page_reporting_drain(prdev, sgl, PAGE_REPORTING_CAPACITY, !err); + page_reporting_drain(prdev, sgl, prdev->capacity, !err); /* * Reset next to first entry, the old next isn't valid @@ -260,13 +260,13 @@ static int page_reporting_process_zone(struct page_reporting_dev_info *prdev, struct scatterlist *sgl, struct zone *zone) { - unsigned int order, mt, leftover, offset = PAGE_REPORTING_CAPACITY; + unsigned int order, mt, leftover, offset = prdev->capacity; unsigned long watermark; int err = 0; /* Generate minimum watermark to be able to guarantee progress */ watermark = low_wmark_pages(zone) + - (PAGE_REPORTING_CAPACITY << page_reporting_order); + (prdev->capacity << page_reporting_order); /* * Cancel request if insufficient free memory or if we failed @@ -290,7 +290,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, } /* report the leftover pages before going idle */ - leftover = PAGE_REPORTING_CAPACITY - offset; + leftover = prdev->capacity - offset; if (leftover) { sgl = &sgl[offset]; err = prdev->report(prdev, sgl, leftover); @@ -322,11 +322,11 @@ static void page_reporting_process(struct work_struct *work) atomic_set(&prdev->state, state); /* allocate scatterlist to store pages being reported on */ - sgl = kmalloc_objs(*sgl, PAGE_REPORTING_CAPACITY); + sgl = kmalloc_objs(*sgl, prdev->capacity); if (!sgl) goto err_out; - sg_init_table(sgl, PAGE_REPORTING_CAPACITY); + sg_init_table(sgl, prdev->capacity); for_each_zone(zone) { err = page_reporting_process_zone(prdev, sgl, zone); @@ -377,6 +377,12 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) page_reporting_order = pageblock_order; } + if (!prdev->capacity || prdev->capacity > PAGE_REPORTING_CAPACITY) + prdev->capacity = PAGE_REPORTING_CAPACITY; + + /* Power of 2 so division by capacity in the budget calc is cheap */ + prdev->capacity = rounddown_pow_of_two(prdev->capacity); + /* initialize state and work structures */ atomic_set(&prdev->state, PAGE_REPORTING_IDLE); INIT_DELAYED_WORK(&prdev->work, &page_reporting_process); -- MST