mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: liulongfang <liulongfang@huawei.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: <shameerali.kolothum.thodi@huawei.com>,
	<jonathan.cameron@huawei.com>, <cohuck@redhat.com>,
	<linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>
Subject: Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration driver
Date: Tue, 21 Mar 2023 10:21:40 +0800	[thread overview]
Message-ID: <41e59e5d-9bf7-2834-4fd1-09ec4c48fa24@huawei.com> (raw)
In-Reply-To: <ZBjTXwZQs603zHy3@nvidia.com>

On 2023/3/21 5:42, Jason Gunthorpe wrote:
> On Mon, Mar 20, 2023 at 03:33:36PM -0600, Alex Williamson wrote:
> 
>> This would allow that mlx5 and future drivers automatically get this
>> with no driver code, and in fact all devices would get debugfs dev_name
>> directories for better test coverage.  hisi_acc would only need to add
>> driver specific entries after registering the device and free any
>> related data after unregistering the device.  In this way, none of the
>> entry points here would need to be exported for drivers, which is
>> perhaps the direction Jason was thinking with his prior comments.
> 
> Yes, my point was more not to add more ops specifically to wrapper
> debugfs stuff. If drivers want a special debugfs file then there is
> lots of infrastructure to just create that off a common point
> 

OK! I understand what you and Alex are asking for.
I will re-debug a version based on your request.

Thanks.
Longfang.
> Jason
> .
> 

  reply	other threads:[~2023-03-21  2:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20  9:23 [PATCH v9 0/5] add debugfs to " Longfang Liu
2023-03-20  9:23 ` [PATCH v9 1/5] vfio/migration: Add debugfs to live " Longfang Liu
2023-03-20 21:33   ` Alex Williamson
2023-03-20 21:42     ` Jason Gunthorpe
2023-03-21  2:21       ` liulongfang [this message]
2023-03-21  2:40     ` liulongfang
2023-03-20  9:23 ` [PATCH v9 2/5] hisi_acc_vfio_pci: extract public functions for container_of Longfang Liu
2023-03-20  9:23 ` [PATCH v9 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver Longfang Liu
2023-03-20 22:09   ` Alex Williamson
2023-03-25  9:39     ` liulongfang
2023-03-20  9:23 ` [PATCH v9 4/5] Documentation: add debugfs description for vfio Longfang Liu
2023-03-20  9:23 ` [PATCH v9 5/5] vfio: update live migration device status Longfang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41e59e5d-9bf7-2834-4fd1-09ec4c48fa24@huawei.com \
    --to=liulongfang@huawei.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®