From: CK Hu <ck.hu@mediatek.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <matthias.bgg@gmail.com>
Cc: <chunkuang.hu@kernel.org>, <airlied@linux.ie>,
Abaci Robot <abaci@linux.alibaba.com>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev_err()
Date: Wed, 4 May 2022 15:49:30 +0800 [thread overview]
Message-ID: <41eb4b05c703d0377b7139ad0868cebea8f6fc47.camel@mediatek.com> (raw)
In-Reply-To: <20220224012318.84935-1-yang.lee@linux.alibaba.com>
Hi, Yang:
On Thu, 2022-02-24 at 09:23 +0800, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/mediatek/mtk_dsi.c:1092:2-9: line 1092 is redundant
> because platform_get_irq() already prints an error
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index bced4c7d668e..704252ee1198 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1089,7 +1089,6 @@ static int mtk_dsi_probe(struct platform_device
> *pdev)
>
> irq_num = platform_get_irq(pdev, 0);
> if (irq_num < 0) {
> - dev_err(&pdev->dev, "failed to get dsi irq_num: %d\n",
> irq_num);
> ret = irq_num;
> goto err_unregister_host;
> }
prev parent reply other threads:[~2022-05-04 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 1:23 Yang Li
2022-05-04 7:49 ` CK Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41eb4b05c703d0377b7139ad0868cebea8f6fc47.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®